Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [sc-103119] URI is not replacing the spec but merging instead #1537

Merged
merged 1 commit into from
Apr 30, 2024
Merged

feat: [sc-103119] URI is not replacing the spec but merging instead #1537

merged 1 commit into from
Apr 30, 2024

Conversation

nvanthao
Copy link
Member

@nvanthao nvanthao commented Apr 30, 2024 •
edited
Loading

Description, Motivation and Context

Fixes: #1486
Demo: https://asciinema.org/a/ejHWTp8liwS7p1JOCfzkp917U

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

This will change existing behavior where user is running support-bundle binary directly on their spec. Instead of merging uri and original spec, now only uri spec will be used. But it is aligning with our document

@nvanthao nvanthao added the type::bug Something isn't working label Apr 30, 2024
@nvanthao nvanthao requested a review from a team as a code owner April 30, 2024 00:10
@DexterYan DexterYan merged commit c2f72ec into main Apr 30, 2024
27 checks passed
@DexterYan DexterYan deleted the gerard/sc-103119/b-merge-uri branch April 30, 2024 02:13
banjoh added a commit to banjoh/troubleshoot that referenced this pull request May 1, 2024
@banjoh
Revert "feat: [sc-103119] URI is not replacing the spec but merging i…
e83664f 
…nstead (replicatedhq#1537)"

This reverts commit c2f72ec.
@banjoh banjoh mentioned this pull request May 1, 2024
Merged
6 tasks
banjoh added a commit that referenced this pull request May 1, 2024
@banjoh
Revert "feat: URI is not replacing the spec but merging instead (#1537)…
aeaac7a 
… (#1539)

Revert "feat: [sc-103119] URI is not replacing the spec but merging instead (#1537)"

This reverts commit c2f72ec.
@nvanthao nvanthao mentioned this pull request May 2, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DexterYan DexterYan DexterYan approved these changes

Assignees
No one assigned
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URI is not replacing the spec but merging instead
2 participants
@nvanthao @DexterYan