Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show progress when collecting support bundle #43

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Show progress when collecting support bundle #43

merged 1 commit into from
Aug 7, 2019

Conversation

divolgin
Copy link
Member

@divolgin divolgin commented Aug 7, 2019

No description provided.

marccampbell
marccampbell reviewed Aug 7, 2019
View reviewed changes
Copy link
Member

@marccampbell marccampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. One question about the channel, and a request to put this in preflight so we have the same cursor hide/show behavior.

cmd/troubleshoot/cli/run_nocrd.go Outdated Show resolved Hide resolved
cmd/troubleshoot/cli/run_nocrd.go Outdated Show resolved Hide resolved
@divolgin divolgin force-pushed the progress branch 2 times, most recently from 4df981e to 17daf0c Compare August 7, 2019 19:34
@divolgin divolgin merged commit f9efac3 into master Aug 7, 2019
@divolgin divolgin deleted the progress branch August 7, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marccampbell marccampbell marccampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divolgin @marccampbell