GraalVM native-image build support #337

whilo · 2021-05-25T05:46:05Z

This branch provides a prototype CLI tools built as a native image. The build uses https://github.com/taylorwood/clj.native-image. Preliminary documentation for the CLI can be found under doc/cli.md.

…#337.

jsmassa · 2022-01-08T03:18:10Z

Needs an update to pass the tests.

jsmassa · 2022-08-31T15:03:01Z

tests.edn

@@ -3,6 +3,6 @@
                    #_{:id :cljs
                       :type :kaocha.type/cljs
                       :ns-patterns ["datahike.test."]}
-                    {:id :integration
+                    #_{:id :integration


Needs to be uncommented and working

jsmassa · 2022-09-23T11:23:21Z

Blocked by #542

whilo · 2022-10-20T10:15:58Z

@jsmassa Except for the backward-compatibility-test this should be ready to be merged now. Let me know what needs to be changed for this or feel free to fix it directly. konserve after merge of replikativ/konserve#79 and the hitchhiker-tree also need to be released and changed in the dependencies.

This PR now only makes sure that the native-image can be built and works (tests not yet integrated, they are in bin/run-native-image-tests). I have left all changes to the memory model for #332 or follow-ups.

* fixup! ci: add pipeline for native-image

* fixup! ci: correct env backward-compatibility-tests (#569)

jsmassa

Looks good to me. But as you say, it needs proper release versions for the dependencies and some benchmark checks

* ci: add native-image test

Shorten command line tool name.

jsmassa

Looks good to me in general.

I am personally not a big fan of the package / directory name 'impl' though as it doesn't really say anything about the content. Since 'java' is taken, I guess I would choose something like 'interop' or 'native' in this case. But since we will have to do some restructuring anyway when changing to polylith, I am also ok with leaving it as is for now.

.circleci/config.yml

whilo · 2022-12-23T07:41:06Z

I agree, I strongly dislike impl as well unless it would disambiguate internals of something that is already scoped and then internal would probably be better. I actually tried native but native is a protected keyword in Java, so we would have to use something else. I inherited impl from libsci actually.

* Use konserve synchronous IO. Support native-image compilation. * Remove sleeping to make times match. * Handler InterruptedException. * ci: add pipeline for native-image * fixup! ci: add pipeline for native-image * 336 native image cli (#568) * fixup! ci: add pipeline for native-image * ci: correct env backward-compatibility-tests (#569) * changed ci and script to improve local run (#570) * fixup! ci: correct env backward-compatibility-tests (#569) * from-datom slipped in again during rebase; remove. * Use released versions of hh-tree and konserve. * ci: add native-image test (#573) * ci: add native-image test * Try konserve version that detects small headers for backwards compat. * Use release version of konserve * Fix reflection error. * Update Java API, export as native shared lib, update native cli. * Add resources. * Complete CLI interface. * Update help for cli. * Add CBOR serialization. * Fix format. * Support different formats for transact piping and inputs. * Handle variable input/output formats, exceptions in shared library. Shorten command line tool name. * Handle memory of return type through callback. * Complete first stage shared library and cli. * Fix cicrcleci path to cli. * Ensure UTF8 encoding. * Use base64 encoding for CBOR for now to avoid char* truncation. Co-authored-by: Timo Kramer <fw-github@timokramer.de> Co-authored-by: Timo Kramer <4785848+TimoKramer@users.noreply.github.com> Co-authored-by: Judith <j.massa@lambdaforge.io>

whilo marked this pull request as draft May 25, 2021 05:46

whilo added a commit that referenced this pull request May 31, 2021

Factor datahike-server-transactor into separate project. Backport from …

5dc97be

…#337.

whilo mentioned this pull request Sep 16, 2021

Connect to existing filestore created in different process fails #387

Open

kordano requested a review from jsmassa November 18, 2021 15:08

whilo mentioned this pull request Nov 23, 2021

[Bug]: store max-ent-id in db record #440

Closed

whilo changed the base branch from development to 60-add-documentation December 22, 2021 21:36

whilo changed the base branch from 60-add-documentation to main December 22, 2021 21:36

whilo marked this pull request as ready for review December 22, 2021 21:37

jsmassa reviewed Aug 31, 2022

View reviewed changes

whilo force-pushed the 336-native-image-cli branch 2 times, most recently from b20f3e2 to 5127656 Compare October 20, 2022 09:56

Use konserve synchronous IO. Support native-image compilation.

4f4bdf1

whilo force-pushed the 336-native-image-cli branch from 5127656 to 4f4bdf1 Compare October 20, 2022 10:05

whilo added 2 commits October 20, 2022 03:07

Remove sleeping to make times match.

59dbc32

Handler InterruptedException.

d5c13a9

whilo requested a review from jsmassa October 20, 2022 10:16

TimoKramer and others added 5 commits October 21, 2022 16:45

ci: add pipeline for native-image

2eacfe0

fixup! ci: add pipeline for native-image

b0fe304

336 native image cli (#568)

28494cb

* fixup! ci: add pipeline for native-image

ci: correct env backward-compatibility-tests (#569)

e2c4b9f

changed ci and script to improve local run (#570)

e469fdf

* fixup! ci: correct env backward-compatibility-tests (#569)

jsmassa reviewed Oct 27, 2022

View reviewed changes

whilo and others added 5 commits October 27, 2022 12:59

from-datom slipped in again during rebase; remove.

b239761

Use released versions of hh-tree and konserve.

31055b9

ci: add native-image test (#573)

b8c1e32

* ci: add native-image test

Try konserve version that detects small headers for backwards compat.

063bdc2

Use release version of konserve

57cce0a

whilo added 6 commits November 19, 2022 15:05

Merge main.

19f9520

Fix reflection error.

04b5f23

Merge branch 'main' into 336-native-image-cli

45b55e0

Update Java API, export as native shared lib, update native cli.

a09170c

Add resources.

75ac81c

Complete CLI interface.

4f49b08

whilo marked this pull request as draft November 24, 2022 09:22

whilo added 8 commits November 24, 2022 01:31

Update help for cli.

c82c41a

Add CBOR serialization.

4eb5a39

Fix format.

64a3bb8

Support different formats for transact piping and inputs.

e828a8d

Handle variable input/output formats, exceptions in shared library.

8c4eabb

Shorten command line tool name.

Handle memory of return type through callback.

bc79b05

Complete first stage shared library and cli.

5beae77

Fix cicrcleci path to cli.

2f7eb05

whilo marked this pull request as ready for review December 9, 2022 05:38

whilo added 2 commits December 9, 2022 12:01

Ensure UTF8 encoding.

a741c26

Use base64 encoding for CBOR for now to avoid char* truncation.

6438662

jsmassa reviewed Dec 22, 2022

View reviewed changes

.circleci/config.yml Show resolved Hide resolved

jsmassa approved these changes Dec 22, 2022

View reviewed changes

whilo merged commit 35773c5 into main Dec 23, 2022

whilo deleted the 336-native-image-cli branch March 5, 2023 02:45

whilo mentioned this pull request Mar 16, 2023

GraalVM native image support #336

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GraalVM native-image build support #337

GraalVM native-image build support #337

whilo commented May 25, 2021

jsmassa commented Jan 8, 2022

jsmassa Aug 31, 2022

jsmassa commented Sep 23, 2022

whilo commented Oct 20, 2022 •

edited

Loading

jsmassa left a comment

jsmassa left a comment

whilo commented Dec 23, 2022

GraalVM native-image build support #337

GraalVM native-image build support #337

Conversation

whilo commented May 25, 2021

jsmassa commented Jan 8, 2022

jsmassa Aug 31, 2022

Choose a reason for hiding this comment

jsmassa commented Sep 23, 2022

whilo commented Oct 20, 2022 • edited Loading

jsmassa left a comment

Choose a reason for hiding this comment

jsmassa left a comment

Choose a reason for hiding this comment

whilo commented Dec 23, 2022

whilo commented Oct 20, 2022 •

edited

Loading