Keypress event (conditional) trigger

[arichiardi]

This is an implementation of the key press trigger.

It is conditional because if you push a function(current_text, new_char) with SetKeyPressPredicate and your function returns false (default), no event is triggered. This is done cause you might want to add logic, say, if the last word of the current text + new_char is a keyword then trigger, you can achieve it here.

It works quite nicely here 👍

Please let me know if I have been too prolific with the function names 😄

[amasad]

what is this for?

[arichiardi]

It is for identifying the part of the prompt that is changed by the user. This was useful for implementing highlighting (with highlight.js) but maybe there are other way that I am not considering (not js expert here 😄)

[arichiardi]

Oh we use GetPromptText great!

[amasad]

Looks good. Can you add an example usage? Would be great to add the documentation too.

[arichiardi]

Where do you want me to add the usage? In the coffee or in the README ?

[amasad]

Read me and an example usage would be great!

On Saturday, November 7, 2015, Andrea Richiardi notifications@github.com
wrote:

Where do you want me to add the usage? In the coffee or in the README ?

—
Reply to this email directly or view it on GitHub
#81 (comment).

[arichiardi]

Ok done, have a look in index.html and tell me if it's good 😄

[amasad]

That's very cool. Thank you. Will do a release soon after I fix #80

[arichiardi]

👍 thanks, as before I would like to push a release in cljsjs too. I am relying on jqconsole for an upcoming app and a fast release would really make my job more comfortable. Thanks for the library if I haven't already told you 😄

[amasad]

I'd like to simplify this a little bit. Instead of having two different handlers, let's make it a single step. The user gets to execute the handler before the internal handler with no auxiliary events needed. So the example would be.

jqconsole.SetKeyPressHandler(function (e) {
  // do stuff
  // the internal handler should not execute.
  return false;
});

[amasad]

I'll send a PR and let me know what you think

[arichiardi]

Ok, I put two because one gives the "pace" of the triggering (I don't won't to trigger every keypress for instance), the other handles.
In any case, I will wait for your PR :)

[amasad]

see #82 gives us the full potential for auto-complete and other user-defined behavior