Remove const modifier from result type #91
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
const
generic modifier to our result functions makes it so that it's not possible to pass in arrays (possibly other things that are affected) toOk
(orErr
).For example
I honestly don't understand what's going on here, and why we added the const modifier in the first place, so let me know if we should find another way to fix this.
Maybe we meant to do this instead? Produce a read-only result.