Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add @replit/ruspty-darwin-arm64 #3

Closed
wants to merge 10 commits into from
Closed

Conversation

jackyzha0
Copy link
Member

@jackyzha0 jackyzha0 commented Apr 3, 2024

m1 :)

  • building works on my m1
  • tests also pass (but only before bun 1.0.30, seems like they broke something upstream)

@jackyzha0 jackyzha0 requested a review from szymonkaliski April 3, 2024 23:39
@szymonkaliski
Copy link
Member

This is great but we should make the CI happy otherwise the build won't appear on npm anyways; also worth updating the nix stuff too I guess:

devShells.x86_64-darwin.default = mkDevShell "x86_64-darwin";

@jackyzha0
Copy link
Member Author

hmm do i need to update it? it seems like it has the right entries already unless im missing something

    devShells.aarch64-darwin.default = mkDevShell "aarch64-darwin";
    devShells.x86_64-darwin.default = mkDevShell "x86_64-darwin";

@szymonkaliski
Copy link
Member

oh right lol

@jackyzha0
Copy link
Member Author

@szymonkaliski hm the test seems to fail on macos latest but works on macos 13??

@szymonkaliski
Copy link
Member

No idea! We should probably target the latest, so worth investigating further I guess.

@szymonkaliski
Copy link
Member

closing for now, macos is not a priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants