3.2.4 createRequire to allow copy loader from esbuild to work in SEA
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyzha0
changed the title
createRequire to allow copy loader from esbuild to work in SEA
masad-frost
approved these changes
Oct 8, 2024
| @@ -6,6 +6,8 @@ | |||
|
|
|||
| const { existsSync, readFileSync } = require('fs') | |||
| const { join } = require('path') | |||
| const { createRequire } = require('node:module') | |||
| require = createRequire(__filename) | |||
There was a problem hiding this comment.
Why not const require make it local?
There was a problem hiding this comment.
🤷 the node docs recommend it like this, i assume theres some static analysis things at work here
no it should still bundle ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JS Bindings that NAPI-RS produces use raw require calls for local files.
With esbuild, this is normally fine as you can use the copy loader to just move the .node addon to the right place but SEAs dont allow requiring from the fs: nodejs.org/docs/latest-v20.x/api/single-executable-applications.html#requireid-in-the-injected-main-script-is-not-file-based
They recommend using createRequire instead
This change should allow native addons created by NAPI-RS to be used in SEAs