Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix provider and dist removal #168

Merged
merged 1 commit into from
May 21, 2020

Conversation

karniv00l
Copy link
Contributor

We need to leave vendor folder since more packages may be under it

@karniv00l karniv00l requested a review from akondas May 20, 2020 20:19
@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #168 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #168   +/-   ##
=========================================
  Coverage     99.87%   99.87%           
- Complexity     1176     1177    +1     
=========================================
  Files           203      203           
  Lines          3329     3332    +3     
=========================================
+ Hits           3325     3328    +3     
  Misses            4        4           
Impacted Files Coverage Δ Complexity Δ
...Handler/Organization/RemoveOrganizationHandler.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...ssageHandler/Organization/RemovePackageHandler.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
src/Service/Organization/PackageManager.php 100.00% <100.00%> (ø) 15.00 <2.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2481e8...79726e9. Read the comment docs.

@akondas akondas merged commit ba6ac23 into repman-io:master May 21, 2020
@karniv00l karniv00l deleted the fix-package-remove branch May 22, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants