Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repman:create:user command #181

Merged
merged 1 commit into from
May 28, 2020

Conversation

nickygerritsen
Copy link
Contributor

Part of #159

@akondas
Copy link
Member

akondas commented May 27, 2020

It seems to me that we can safely add another command, a slight duplication here will not hurt and there will be a better separation of the concept.

@nickygerritsen
Copy link
Contributor Author

OK done 😄

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #181 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #181   +/-   ##
=========================================
  Coverage     99.88%   99.88%           
- Complexity     1178     1181    +3     
=========================================
  Files           203      204    +1     
  Lines          3335     3352   +17     
=========================================
+ Hits           3331     3348   +17     
  Misses            4        4           
Impacted Files Coverage Δ Complexity Δ
src/Command/CreateAdminCommand.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
src/Command/CreateUserCommand.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22dbc71...c377dd3. Read the comment docs.

@akondas
Copy link
Member

akondas commented May 27, 2020

Well done, rebase please and we can merge this 👍

@nickygerritsen
Copy link
Contributor Author

Done :)

@nickygerritsen nickygerritsen changed the title Change repman:create:admin to repman:create:user and allow it to create non-admin users Add repman:create:user command May 27, 2020
@akondas
Copy link
Member

akondas commented May 28, 2020

Thanks 👍

@akondas akondas merged commit 57e599c into repman-io:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants