Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Storage interface and replace by StorageImpl #366

Merged

Conversation

pedro-stanaka
Copy link
Contributor

This is the cleanup I promised, removing the Storage interface to avoid confusion since it will only have one implementation. Moreover, I didnt make the class final, otherwise we won't be able to mock it with prophecy lib.

Feel free to close/ignore if you think this is not needed.

@pedro-stanaka pedro-stanaka force-pushed the refactor/storage-interface-cleanup branch from f4dbfe6 to 8a7d397 Compare January 7, 2021 17:02
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #366 (ccb12d2) into master (b863acd) will not change coverage.
The diff coverage is 89.09%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #366   +/-   ##
=========================================
  Coverage     99.35%   99.35%           
  Complexity     1855     1855           
=========================================
  Files           297      297           
  Lines          5858     5858           
=========================================
  Hits           5820     5820           
  Misses           38       38           
Impacted Files Coverage Δ Complexity Δ
src/Service/Dist/Storage.php 89.09% <89.09%> (ø) 17.00 <17.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b863acd...ccb12d2. Read the comment docs.

Copy link
Member

@akondas akondas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering about the namespace. I really like the changes themselves. What about:

Buddy\Repman\Service\Dist\Storage

(without second Storage)

I apologize in advance for the late pace, but this week will still be quite busy for me 😉

@pedro-stanaka
Copy link
Contributor Author

No worries, we all have those weeks. I moved the class now, the namespace was strange really.

@akondas akondas merged commit 61b6072 into repman-io:master Jan 18, 2021
@akondas
Copy link
Member

akondas commented Jan 18, 2021

Thanks @pedro-stanaka 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants