-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve organization invitation with registration/login flow #387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I like this change, what do you say to leave one button and do it like this:
The route "organization_accept_invitation" could be opened (available without logging in). In its action, it could be detected if the user is logged in, if not a redirection with 'invitationtoken to login (and then the same on the login action, you would have to render the button for registration with
invitation` token)
@akondas thanks for your review |
5bb1c92
to
99877a2
Compare
@akondas code is rewritten, I am testing it now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change and we are ready to go 😉 👍
2e6c771
to
59eabe3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
@noniagriconomie Also let me know if you will be able to do a rebase or can I help with it? |
59eabe3
to
4638938
Compare
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
============================================
- Coverage 99.48% 99.31% -0.17%
- Complexity 1850 1853 +3
============================================
Files 297 297
Lines 5828 5846 +18
============================================
+ Hits 5798 5806 +8
- Misses 30 40 +10
Continue to review full report at Codecov.
|
4638938
to
36b50c3
Compare
36b50c3
to
ef7c255
Compare
@akondas PR rebased and comment addressed for the security access control |
Thanks @noniagriconomie 🙏 |
Hello
Here is a PR that tries to improve the organization invitation process flow
fixes #381
Friendly ping @akondas
Thank you,