Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to Google Maps #67

Merged

Conversation

timtroendle
Copy link
Member

I've added links to Google maps to the data table.

However, this is impacted by #66. I added some cleaning routines, but didn't manage to cover all issues of the "Location_coordinates" column. I suggest to not merge this before #66 is fixed.

@timtroendle timtroendle added the website Related to the website, not the dataset. label Nov 16, 2020
@timtroendle
Copy link
Member Author

This is a simplified version of #41 .

@timtroendle
Copy link
Member Author

The table is now too broad. It works fine on larger screens, but on my tablet, it doesn't fit on the screen.

@richard-thonig
Copy link
Member

a) The map appears in the "map view" of google map instead of the sattelite view. ist there maybe the right keyword missing?
b) is there a way to strip "spaces" from the search term. It seems to fail, for the very first link because of spaces.

@timtroendle
Copy link
Member Author

a) I did not find a way for that unfortunately. I think it's not possible.
b) I do remove whitespace, but this is non-breaking whitespace, see #66. Instead of trying to fix this here, I think we should rather fix the data.

@richard-thonig
Copy link
Member

right.
a) yes. seems to be a problem with using search, vs explicitly pointing to a location
b) fixed it in the new version.

@richard-thonig
Copy link
Member

@timtroendle In the new version of the data I changed them to consistently use decimal point i.e -27.734,23.063
This should allow us to use the explicit formating and satelite as well as zoom parameters in the google-maps link?

@timtroendle
Copy link
Member Author

I will look into it after #64 is merged.

@richard-thonig
Copy link
Member

@timtroendle in the website update PR, I saw that the first collumn seems to be broken:
maybe this can be fixed in this PR as well?
grafik

@timtroendle
Copy link
Member Author

Did you rename the "name" field?

Locations are now consistently given in decimals and thus do not require text handling anymore.
@timtroendle
Copy link
Member Author

For reference: this is the descrption of Googles API:

https://developers.google.com/maps/documentation/urls/get-started

@timtroendle
Copy link
Member Author

@richard-thonig Can you review this again? With locations given in decimals now, this should work better than before.

Copy link
Member

@richard-thonig richard-thonig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use the explicit version of the link. I gave it shot and it worked. Hurray!

@timtroendle
Copy link
Member Author

Very nice. Looks great!

@timtroendle timtroendle merged commit 8917272 into repolicy:website Dec 3, 2020
@timtroendle timtroendle deleted the feature-link-to-google-maps branch December 3, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Related to the website, not the dataset.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants