-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to Google Maps #67
Add link to Google Maps #67
Conversation
This is a simplified version of #41 . |
The table is now too broad. It works fine on larger screens, but on my tablet, it doesn't fit on the screen. |
a) The map appears in the "map view" of google map instead of the sattelite view. ist there maybe the right keyword missing? |
a) I did not find a way for that unfortunately. I think it's not possible. |
right. |
@timtroendle In the new version of the data I changed them to consistently use decimal point i.e -27.734,23.063 |
I will look into it after #64 is merged. |
@timtroendle in the website update PR, I saw that the first collumn seems to be broken: |
Did you rename the "name" field? |
Locations are now consistently given in decimals and thus do not require text handling anymore.
For reference: this is the descrption of Googles API: https://developers.google.com/maps/documentation/urls/get-started |
6ab9bb0
to
8dc9fab
Compare
@richard-thonig Can you review this again? With locations given in decimals now, this should work better than before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use the explicit version of the link. I gave it shot and it worked. Hurray!
Very nice. Looks great! |
I've added links to Google maps to the data table.
However, this is impacted by #66. I added some cleaning routines, but didn't manage to cover all issues of the "Location_coordinates" column. I suggest to not merge this before #66 is fixed.