Skip to content

Commit

Permalink
Fix for issue #195
Browse files Browse the repository at this point in the history
  • Loading branch information
HardNorth committed Sep 16, 2022
1 parent 1b4db05 commit 41a5e0e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## [Unreleased]
### Fixed
- Issue [#194](https://github.com/reportportal/client-Python/issues/194): logging URL generation, by @HardNorth
- Issue [#195](https://github.com/reportportal/client-Python/issues/195): `None` mode exception

## [5.2.4]
### Changed
Expand Down
10 changes: 6 additions & 4 deletions reportportal_client/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -310,11 +310,13 @@ def start_launch(self,
# We are moving 'mode' param to the constructor, next code for the
# transition period only.
my_kwargs = dict(kwargs)
mode = my_kwargs.get('mode')
if not mode:
mode = self.mode
else:
if 'mode' in my_kwargs.keys():
mode = my_kwargs['mode']
del my_kwargs['mode']
if not mode:
mode = self.mode
else:
mode = self.mode

request_payload = LaunchStartRequest(
name=name,
Expand Down

0 comments on commit 41a5e0e

Please sign in to comment.