Force finish (stopping) launch added

[tmarenko]

No description provided.

[krasoffski]

stop_launch is almost the same as finish_launch except s/finish_/stop_/.
It would be great to create a common method like _finalize_launch or any other name you like with semantics _finalize_launch(self, end_time, status=None, method="finish"). But it is required to check clients which use this lib because of semantics changes. What do you think about that?

[ailjushkin]

@krasoffski I think that it is better to follow the original API while doing such packages to work with it. Mapping method to method looks much more clear than some mixed method doing multiple things. So the idea not in functionality of the package itself but in following functionality of the base product.

So here I would stay this code as it is now.

[ailjushkin]

@tmarenko also you need to update the package version to be able to upload it on pypi.

[ailjushkin]

@tmarenko allright, I have removed my comment about the stack pop. Let's stay it as it is. But you need to bump the version to be able to upload that package on pypi.

[ailjushkin]

Thanks.

[krasoffski]

@tmarenko, @ailjushkin Thank you for you effort. There is one more option to reduce copy&paste for now, just an example:

def _finalize_launch(self, end_time, action, status):
    data = {
        "end_time": end_time,
        "status": status
    }
    url = uri_join(self.base_url, "launch", self.launch_id, action)
    r = self.session.put(url=url, json=data)
    self.stack.pop()
    logger.debug("%s_launch - Stack: %s", action, self.stack)
    return _get_msg(r)

And then two non-private methods like:

 def finish_launch(self, end_time, status=None):
    return self._finalize_launch(end_time=end_time, action="finish", status=status)

and

 def stop_launch(self, end_time, status=None):
    return self._finalize_launch(end_time=end_time, action="stop", status=status)

Could you please try this solution?

[krasoffski]

Sorry for my severity.

[ailjushkin]

@krasoffski sounds awesome, thanks

[krasoffski]

Despite the fact that it was possible to perform the similar changes for service_async.py file, it's not worth it to save two lines of code.

[krasoffski]

@avarabyeu, @DzmitryHumianiuk
Could you please merge this request?