User pre-upgrade hook instead ttlSecondsAfterFinished (#407)

* Change ttlSecondsAfterFinished with pre-upgrade hook

* chore: Update service account permissions for service-manager role

reportportal/templates/authorization/role.yaml

@@ -2,15 +2,19 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
-  name: {{ include "reportportal.fullname" . }}-service-reader
+  name: {{ include "reportportal.fullname" . }}-service-manager
   namespace: {{ .Release.Namespace }}
 rules:
   {{- if .Values.rbac.rules }}
     {{- toYaml .Values.rbac.rules | nindent 4 }}
   {{- else }}
+  # Allow the service account to get and list pods, services, and jobs
   - apiGroups: ["", "batch"]
     resources: ["pods","services", "jobs"]
     verbs: ["get", "list", "watch"]
+  # Allow the service account to delete jobs
+  - apiGroups: ["batch"]
+    resources: ["jobs"]
+    verbs: ["delete"]
   {{- end}}
-
 {{- end }}

reportportal/templates/authorization/rolebinding.yaml

@@ -2,14 +2,14 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
-    name: {{ include "reportportal.fullname" . }}-user-binding
-    namespace: {{ .Release.Namespace }}
+  name: {{ include "reportportal.fullname" . }}-user-binding
+  namespace: {{ .Release.Namespace }}
 roleRef:
-    apiGroup: rbac.authorization.k8s.io
-    kind: Role
-    name: {{ include "reportportal.fullname" . }}-service-reader
+  apiGroup: rbac.authorization.k8s.io
+  kind: Role
+  name: {{ include "reportportal.fullname" . }}-service-manager
 subjects:
-    - kind: ServiceAccount
-      name: {{ template "reportportal.serviceAccountName" . }}
-      namespace: {{ .Release.Namespace }}
+  - kind: ServiceAccount
+    name: {{ template "reportportal.serviceAccountName" . }}
+    namespace: {{ .Release.Namespace }}
 {{- end }}

reportportal/templates/hooks/pre-upgrade-hook.yaml

@@ -0,0 +1,28 @@
+apiVersion: batch/v1
+kind: Job
+metadata:
+  name: {{ include "reportportal.fullname" . }}-pre-upgrade-delete-job
+  labels:
+    {{ include "labels" . | indent 4 }}
+  annotations:
+    "helm.sh/hook": pre-upgrade
+    "helm.sh/hook-delete-policy": hook-succeeded
+spec:
+  template:
+    metadata:
+      labels:
+        {{- range $key, $value := .Values.migrations.podLabels }}
+        {{ $key }}: {{ $value | quote }}
+        {{- end }}
+        component: {{ include "reportportal.fullname" . }}-pre-upgrade-delete-job
+    spec:
+      serviceAccountName: {{ template "reportportal.serviceAccountName" . }}
+      restartPolicy: OnFailure
+      containers:
+      - name: delete-job
+        image: bitnami/kubectl:latest
+        command:
+        - /bin/sh
+        - -c
+        - |
+          kubectl delete job {{ include "reportportal.fullname" . }}-migrations --ignore-not-found=true

reportportal/templates/service-migrations/migrations-job.yaml

@@ -4,7 +4,6 @@ metadata:
   name: {{ include "reportportal.fullname" . }}-migrations
   labels: {{ include "labels" . | indent 4 }}
 spec:
-  ttlSecondsAfterFinished: {{ .Values.migrations.ttlSecondsAfterFinished }}
   template:
     metadata:
       labels:

reportportal/values.yaml

@@ -543,7 +543,6 @@ migrations:
       cpu: 100m
       memory: 128Mi
   pullPolicy: Always
-  ttlSecondsAfterFinished: 600
   podLabels: {}
   podAnnotations: {}
   securityContext: {}