Feature/92628-rmq-shovel-plugin #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbortnik
approved these changes
Jul 11, 2024
tomikonio
reviewed
Aug 13, 2024
| @@ -155,13 +155,8 @@ serviceapi: | |||
| jvmArgs: "-Djava.security.egd=file:/dev/./urandom -XX:+UseG1GC -XX:MinRAMPercentage=60.0 -XX:InitiatingHeapOccupancyPercent=70 -XX:MaxRAMPercentage=90.0 -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/tmp" | |||
|
|
|||
| ## @param serviceapi.queues define the number for the queues | |||
| ## @param serviceapi.queues.totalNumber define the total number of queues | |||
| ## @param serviceapi.queues.perPodNumber define the number of queues per pod | |||
| ## How to calculate: @param serviceapi.queues.perPodNumber = @param serviceapi.queues.totalNumber / @ param serviceapi.replicaCount | |||
There was a problem hiding this comment.
Hi,
Why has this been removed? Is it recommended for the total queue number to be equal to the per-pod number now? (in case we have more than one API pod)
raikbitters
added a commit
that referenced
this pull request
Aug 16, 2024
* Update chart version and image versions * Allow parametrization of DB password key * Global Values & Custom RBAC (#401) * Image registry as global parameter #389 * Improper k8s RBAC API Groups #373 * Update RabbitMQ plugin set (#403) * Update AMQP settings in api-deployment.yaml * Add pre-upgrade hook (#407) * Update analyzer images (#410) --------- Co-authored-by: piotr-smietana-kaseya <piotr.smietana@kaseya.com> Co-authored-by: Hleb Kanonik <hleb_kanonik@epam.com> Co-authored-by: millerick <michael.millerick@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed:
Added: