Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Security Context at Container Level #431

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Added Security Context at Container Level #431

wants to merge 2 commits into from

Conversation

babantax
Copy link

No description provided.

hlebkanonik
hlebkanonik previously approved these changes Nov 12, 2024
View reviewed changes
raikbitters
raikbitters reviewed Nov 12, 2024
View reviewed changes
reportportal/templates/service-api/api-deployment.yaml
@@ -39,6 +39,8 @@ spec:
- name: migrations-waiting-init
image: "{{ include "reportportal.image" (dict "Values" .Values "service" "k8sWaitFor") }}"
imagePullPolicy: IfNotPresent
securityContext:
{{ toYaml .Values.serviceapi.containerSecurityContext | indent 12}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format with nindent

reportportal/templates/service-api/api-deployment.yaml
@@ -56,6 +58,8 @@ spec:
- name: "{{ $.Values.serviceapi.name | default "api" }}"
image: "{{ include "reportportal.image" (dict "Values" .Values "service" "serviceapi") }}"
imagePullPolicy: "{{ .Values.serviceapi.pullPolicy }}"
securityContext:
{{ toYaml .Values.serviceapi.containerSecurityContext | indent 12 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format with nindent

reportportal/templates/service-authorization/uat-deployment.yaml
@@ -40,6 +40,8 @@ spec:
- name: migrations-waiting-init
image: "{{ include "reportportal.image" (dict "Values" .Values "service" "k8sWaitFor") }}"
imagePullPolicy: IfNotPresent
securityContext:
{{ toYaml .Values.uat.containerSecurityContext | indent 12}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format with nindent

reportportal/templates/service-authorization/uat-deployment.yaml
@@ -57,6 +59,8 @@ spec:
- name: "{{ $.Values.uat.name | default "uat" }}"
image: "{{ include "reportportal.image" (dict "Values" .Values "service" "uat") }}"
imagePullPolicy: "{{ .Values.uat.pullPolicy }}"
securityContext:
{{ toYaml .Values.uat.containerSecurityContext | indent 12}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format with nindent

reportportal/templates/service-index/index-deployment.yaml
@@ -35,6 +35,8 @@ spec:
- name: {{ $.Values.serviceindex.name | default "index" }}
image: "{{ include "reportportal.image" (dict "Values" .Values "service" "serviceindex") }}"
imagePullPolicy: "{{ .Values.serviceindex.pullPolicy }}"
securityContext:
{{ toYaml .Values.serviceindex.containerSecurityContext | indent 10}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format with nindent

reportportal/templates/statefullset-auto-analyzer/analyzer-statefulset.yaml
@@ -46,6 +48,8 @@ spec:
- name: "{{ $.Values.serviceanalyzer.name | default "analyzer" }}"
image: "{{ include "reportportal.image" (dict "Values" .Values "service" "serviceanalyzer") }}"
imagePullPolicy: "{{ .Values.serviceanalyzer.pullPolicy }}"
securityContext:
{{ toYaml .Values.serviceanalyzer.containerSecurityContext | indent 10}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format with nindent

reportportal/templates/statefullset-auto-analyzer/analyzertrain-statefulset.yaml
@@ -29,6 +29,8 @@ spec:
- name: migrations-waiting-init
image: "{{ include "reportportal.image" (dict "Values" .Values "service" "k8sWaitFor") }}"
imagePullPolicy: IfNotPresent
securityContext:
{{ toYaml .Values.serviceanalyzertrain.containerSecurityContext | indent 10}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format with nindent

reportportal/templates/statefullset-auto-analyzer/analyzertrain-statefulset.yaml
@@ -46,6 +48,8 @@ spec:
- name: "{{ $.Values.serviceanalyzertrain.name | default "analyzer-train" }}"
image: "{{ include "reportportal.image" (dict "Values" .Values "service" "serviceanalyzer") }}"
imagePullPolicy: "{{ .Values.serviceanalyzertrain.pullPolicy }}"
securityContext:
{{ toYaml .Values.serviceanalyzertrain.containerSecurityContext | indent 10}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format with nindent

reportportal/templates/statefullset-auto-analyzer/metrics-gatherer-deployment.yaml
@@ -28,6 +28,8 @@ spec:
- name: migrations-waiting-init
image: "{{ include "reportportal.image" (dict "Values" .Values "service" "k8sWaitFor") }}"
imagePullPolicy: IfNotPresent
securityContext:
{{ toYaml .Values.metricsgatherer.containerSecurityContext | indent 10}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format with nindent

reportportal/templates/statefullset-auto-analyzer/metrics-gatherer-deployment.yaml
@@ -45,6 +47,8 @@ spec:
- name: metrics-gatherer
image: "{{ include "reportportal.image" (dict "Values" .Values "service" "metricsgatherer") }}"
imagePullPolicy: "{{ .Values.metricsgatherer.pullPolicy }}"
securityContext:
{{ toYaml .Values.metricsgatherer.containerSecurityContext | indent 10}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format with nindent

@hlebkanonik hlebkanonik dismissed their stale review November 12, 2024 15:50

Please change the indentation to nindent for a more human-readable format in the templates

@raikbitters
Copy link
Contributor

@babantax please reformat the text using nindent as it improves the readability of templates.

@raikbitters raikbitters mentioned this pull request Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raikbitters raikbitters raikbitters left review comments

@hlebkanonik hlebkanonik Awaiting requested review from hlebkanonik

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babantax @raikbitters @hlebkanonik