-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix release v5.11.2 #312
Hotfix release v5.11.2 #312
Conversation
Changes into populateUserDetails and populateUserDetailsIfSettingsArePresent for making a role decision according to populate user data.
'uat.image' is changed to 'uat.build' for testing local changes with release services.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
reviewdog
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|69| First sentence of Javadoc is missing an ending period.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|72 col 5| 'member def modifier' has incorrect indentation level 4, expected level should be 2.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|73| First sentence of Javadoc is missing an ending period.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|76 col 5| 'member def modifier' has incorrect indentation level 4, expected level should be 2.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|77| First sentence of Javadoc is missing an ending period.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|80 col 5| 'member def modifier' has incorrect indentation level 4, expected level should be 2.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|82| First sentence of Javadoc is missing an ending period.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|85 col 5| 'member def modifier' has incorrect indentation level 4, expected level should be 2.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|86| First sentence of Javadoc is missing an ending period.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|89 col 5| 'member def modifier' has incorrect indentation level 4, expected level should be 2.
src/main/java/com/epam/reportportal/auth/model/SamlProvidersResource.java|24 col 1| Extra separation in import group before 'javax.validation.Valid'
src/main/java/com/epam/reportportal/auth/model/SamlProvidersResource.java|24 col 1| Wrong lexicographical order for 'javax.validation.Valid' import. Should be before 'lombok.Setter'.
src/main/java/com/epam/reportportal/auth/model/SamlProvidersResource.java|25 col 1| Wrong lexicographical order for 'java.util.List' import. Should be before 'lombok.Setter'.
src/main/java/com/epam/reportportal/auth/model/SamlProvidersResource.java|27 col 1| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/model/SamlProvidersResource.java|31 col 5| 'member def modifier' has incorrect indentation level 4, expected level should be 2.
src/main/java/com/epam/reportportal/auth/integration/parameter/SamlParameter.java
Show resolved
Hide resolved
src/main/java/com/epam/reportportal/auth/integration/parameter/SamlParameter.java
Show resolved
Hide resolved
src/main/java/com/epam/reportportal/auth/integration/parameter/ParameterUtils.java
Show resolved
Hide resolved
src/main/java/com/epam/reportportal/auth/integration/parameter/ParameterUtils.java
Show resolved
Hide resolved
src/main/java/com/epam/reportportal/auth/integration/converter/SamlConverter.java
Show resolved
Hide resolved
src/main/java/com/epam/reportportal/auth/model/SamlProvidersResource.java
Show resolved
Hide resolved
src/main/java/com/epam/reportportal/auth/model/SamlProvidersResource.java
Show resolved
Hide resolved
src/main/java/com/epam/reportportal/auth/model/SamlProvidersResource.java
Show resolved
Hide resolved
src/main/java/com/epam/reportportal/auth/model/SamlProvidersResource.java
Show resolved
Hide resolved
src/main/java/com/epam/reportportal/auth/model/SamlProvidersResource.java
Show resolved
Hide resolved
|
Added support for parsing an admin role attribute in SAML integration.