Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix release v5.11.2 #312

Merged

Conversation

raikbitters
Copy link
Contributor

Added support for parsing an admin role attribute in SAML integration.

@raikbitters raikbitters requested a review from pbortnik June 6, 2024 10:14
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

src/main/java/com/epam/reportportal/auth/model/SamlResource.java|69| First sentence of Javadoc is missing an ending period.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|72 col 5| 'member def modifier' has incorrect indentation level 4, expected level should be 2.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|73| First sentence of Javadoc is missing an ending period.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|76 col 5| 'member def modifier' has incorrect indentation level 4, expected level should be 2.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|77| First sentence of Javadoc is missing an ending period.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|80 col 5| 'member def modifier' has incorrect indentation level 4, expected level should be 2.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|82| First sentence of Javadoc is missing an ending period.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|85 col 5| 'member def modifier' has incorrect indentation level 4, expected level should be 2.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|86| First sentence of Javadoc is missing an ending period.
src/main/java/com/epam/reportportal/auth/model/SamlResource.java|89 col 5| 'member def modifier' has incorrect indentation level 4, expected level should be 2.
src/main/java/com/epam/reportportal/auth/model/SamlProvidersResource.java|24 col 1| Extra separation in import group before 'javax.validation.Valid'
src/main/java/com/epam/reportportal/auth/model/SamlProvidersResource.java|24 col 1| Wrong lexicographical order for 'javax.validation.Valid' import. Should be before 'lombok.Setter'.
src/main/java/com/epam/reportportal/auth/model/SamlProvidersResource.java|25 col 1| Wrong lexicographical order for 'java.util.List' import. Should be before 'lombok.Setter'.
src/main/java/com/epam/reportportal/auth/model/SamlProvidersResource.java|27 col 1| Missing a Javadoc comment.
src/main/java/com/epam/reportportal/auth/model/SamlProvidersResource.java|31 col 5| 'member def modifier' has incorrect indentation level 4, expected level should be 2.

Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@raikbitters raikbitters merged commit 90fde59 into master Jun 6, 2024
6 of 7 checks passed
@raikbitters raikbitters deleted the hotfix/v5.11.2-EPMRPP-91551-saml-admin-role-attribute branch June 6, 2024 16:08
@raikbitters raikbitters restored the hotfix/v5.11.2-EPMRPP-91551-saml-admin-role-attribute branch June 6, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants