Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-90612 || Error in UAT logs when there is no GitHub integration #318

Closed
wants to merge 4 commits into from

Conversation

APiankouski
Copy link
Contributor

No description provided.

oauthProviderId).get()
));
public ResponseEntity<?> getOauthIntegrationById(String oauthProviderId) {
Optional<OAuthRegistration> oAuthRegistrationById = clientRegistrationRepository.findOAuthRegistrationById(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 111).

oauthProviderId).get()
));
public ResponseEntity<?> getOauthIntegrationById(String oauthProviderId) {
Optional<OAuthRegistration> oAuthRegistrationById = clientRegistrationRepository.findOAuthRegistrationById(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.naming.LocalVariableNameCheck> reported by reviewdog 🐶
Local variable name 'oAuthRegistrationById' must match pattern '^a-z?$'.

} else {
Map<String, String> body = new HashMap<>();
body.put("errorCode", String.valueOf(ErrorType.AUTH_INTEGRATION_NOT_FOUND.getCode()));
body.put("message", Suppliers.formattedSupplier("Oauth settings with id = {} have not been found.",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 105).

@@ -122,7 +123,7 @@ public Map<String, OAuthRegistrationResource> getOAuthSettings() {
@ResponseBody
@ResponseStatus(HttpStatus.OK)
@Operation(summary = "Returns OAuth Server Settings")
public OAuthRegistrationResource getOAuthSettings(
public ResponseEntity<?> getOAuthSettings(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> reported by reviewdog 🐶
Abbreviation in name 'getOAuthSettings' must contain no more than '1' consecutive capital letters.

Copy link

sonarcloud bot commented Jul 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@APiankouski APiankouski deleted the EPMRPP-90612 branch July 12, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant