Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-90612 || Error in UAT logs when there is no GitHub integration #319

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

APiankouski
Copy link
Contributor

No description provided.

.orElseGet(() -> {
ExtendedOAuthRegistrationResource body = new ExtendedOAuthRegistrationResource();
body.setErrorCode(ErrorType.AUTH_INTEGRATION_NOT_FOUND.getCode());
body.setMessage(Suppliers.formattedSupplier("Oauth settings with id = {} have not been found.",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 105).

@@ -122,7 +123,7 @@ public Map<String, OAuthRegistrationResource> getOAuthSettings() {
@ResponseBody
@ResponseStatus(HttpStatus.OK)
@Operation(summary = "Returns OAuth Server Settings")
public OAuthRegistrationResource getOAuthSettings(
public ResponseEntity<OAuthRegistrationResource> getOAuthSettings(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> reported by reviewdog 🐶
Abbreviation in name 'getOAuthSettings' must contain no more than '1' consecutive capital letters.

* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.epam.reportportal.auth.model;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck> reported by reviewdog 🐶
'package' should be separated from previous line.

import lombok.Data;
import lombok.EqualsAndHashCode;

/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.

*/
@EqualsAndHashCode(callSuper = true)
@Data
public class ExtendedOAuthRegistrationResource extends OAuthRegistrationResource {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> reported by reviewdog 🐶
Abbreviation in name 'ExtendedOAuthRegistrationResource' must contain no more than '1' consecutive capital letters.

Copy link

sonarcloud bot commented Jul 12, 2024

@APiankouski APiankouski merged commit 0a9bb27 into develop Jul 15, 2024
7 checks passed
@APiankouski APiankouski deleted the EPMRPP-90612-hide-logs branch July 15, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant