-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPMRPP-90612 || Error in UAT logs when there is no GitHub integration #319
Conversation
.orElseGet(() -> { | ||
ExtendedOAuthRegistrationResource body = new ExtendedOAuthRegistrationResource(); | ||
body.setErrorCode(ErrorType.AUTH_INTEGRATION_NOT_FOUND.getCode()); | ||
body.setMessage(Suppliers.formattedSupplier("Oauth settings with id = {} have not been found.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than 100 characters (found 105).
@@ -122,7 +123,7 @@ public Map<String, OAuthRegistrationResource> getOAuthSettings() { | |||
@ResponseBody | |||
@ResponseStatus(HttpStatus.OK) | |||
@Operation(summary = "Returns OAuth Server Settings") | |||
public OAuthRegistrationResource getOAuthSettings( | |||
public ResponseEntity<OAuthRegistrationResource> getOAuthSettings( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abbreviation in name 'getOAuthSettings' must contain no more than '1' consecutive capital letters.
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package com.epam.reportportal.auth.model; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'package' should be separated from previous line.
import lombok.Data; | ||
import lombok.EqualsAndHashCode; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary javadoc is missing.
*/ | ||
@EqualsAndHashCode(callSuper = true) | ||
@Data | ||
public class ExtendedOAuthRegistrationResource extends OAuthRegistrationResource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abbreviation in name 'ExtendedOAuthRegistrationResource' must contain no more than '1' consecutive capital letters.
|
No description provided.