-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ElasticSearch variables to have common configuration names for #2022 #144
base: develop
Are you sure you want to change the base?
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@Kanaduchi Could you please update the PR? |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Updated |
Codecov Report
@@ Coverage Diff @@
## develop #144 +/- ##
========================================
Coverage 72.13% 72.13%
========================================
Files 39 39
Lines 4855 4855
========================================
Hits 3502 3502
Misses 1353 1353
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -75,7 +75,7 @@ | |||
"filesystemDefaultPath": os.getenv("FILESYSTEM_DEFAULT_PATH", "storage").strip(), | |||
"esChunkNumber": int(os.getenv("ES_CHUNK_NUMBER", "1000")), | |||
"esChunkNumberUpdateClusters": int(os.getenv("ES_CHUNK_NUMBER_UPDATE_CLUSTERS", "500")), | |||
"esProjectIndexPrefix": os.getenv("ES_PROJECT_INDEX_PREFIX", "").strip(), | |||
"esProjectIndexPrefix": os.getenv("ES_PROJECT_INDEX_PREFIX", "rp_").strip(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HardNorth, what do you think about this idea? Is it a good one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will break existing deployments unless users regenerate indexes, so this should be introduced only with force index regeneration.
This PR was made according reportportal/reportportal#2022
The mess of ES hosts in the docker-compose file leads to confusion. Currently, each service has its own syntax from ES property.
I changed names to have common format. Also this fix returns missing esProjectIndexPrefix