adjust linter configuration

make sure all actions use the same compiler version

.github/workflows/build.yml

@@ -50,8 +50,6 @@ jobs:
           args:
             --timeout=10m
             --fast
-            --disable=errcheck
-            --disable=gas
 
       - name: Go Tests
         id: tests

.golangci.yml

@@ -11,15 +11,9 @@ linters-settings:
         deny:
           - pkg: io/ioutil
             desc: "replaced by io and os packages since Go 1.16: https://tip.golang.org/doc/go1.16#ioutil"
-  govet:
-    check-shadowing: true
-  golint:
-    min-confidence: 0.8
   gocyclo:
     min-complexity: 10
     max-complexity: 12
-  maligned:
-    suggest-new: true
   dupl:
     threshold: 500
   goconst:
@@ -31,6 +25,8 @@ linters-settings:
     line-length: 140
   goimports:
     local-prefixes: github.com/reportportal/service-index
+  gci:
+    local-prefixes: github.com/reportportal/service-index
   gocritic:
     enabled-tags:
       - performance
@@ -46,26 +42,20 @@ linters-settings:
       - docStub
 
 linters:
-  enable-all: true
+  presets:
+    - bugs
+    - comment
+    - complexity
+    - error
+    - format
+    - import
+    - metalinter
+    - performance
+    - unused
   disable:
-    - prealloc
-    - gochecknoglobals
-    - gocyclo
+    - godot
     - gocritic
-    - interfacer
-    - wsl
     - funlen
-    - unused
-    - gomnd
-    - godot
-    - exhaustivestruct
-    - exhaustruct
-    - varnamelen
-    - gci
-    - nosnakecase
-    - ifshort
-    - scopelint
-    - depguard
 run:
   # default concurrency is a available CPU number
   concurrency: 1

Makefile

@@ -40,8 +40,9 @@ lint: checkstyle
 
 fmt:
 	gofmt -l -w -s ${GOFILES_NOVENDOR}
-	goimports -local "github.com/reportportal/service-index" -l -w ${GOFILES_NOVENDOR}
 	gofumpt -l -w ${GOFILES_NOVENDOR}
+	goimports -local github.com/reportportal/service-index -w ${GOFILES_NOVENDOR}
+	gci write --skip-generated --section Standard --section Default --section "Prefix(github.com/reportportal/service-index)" ${GOFILES_NOVENDOR}
 
 # Builds server
 build:

k8s/k8s.go

@@ -15,9 +15,7 @@ import (
 	log "github.com/sirupsen/logrus"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/client-go/kubernetes"
-
-	// all auth types are supported
-	_ "k8s.io/client-go/plugin/pkg/client/auth"
+	_ "k8s.io/client-go/plugin/pkg/client/auth" // all auth types are supported
 	"k8s.io/client-go/rest"
 )
 

traefik/traefik.go

@@ -3,7 +3,6 @@ package traefik
 import (
 	"errors"
 	"fmt"
-	"github.com/vulcand/predicate"
 	"net/http"
 	"net/url"
 	"strings"
@@ -12,6 +11,7 @@ import (
 
 	"github.com/go-resty/resty/v2"
 	log "github.com/sirupsen/logrus"
+	"github.com/vulcand/predicate"
 )
 
 const (
@@ -284,13 +284,18 @@ func getPath(s string) (string, error) {
 		},
 	})
 	if err != nil {
-		return "", err
+		return "", errPathParsing
 	}
 	pr, err := p.Parse(s)
 	if err != nil {
-		return "", err
+		return "", errPathParsing
 	}
-	return pr.(string), nil
+	prefix, ok := pr.(string)
+	if !ok {
+		return "", errPathParsing
+	}
+
+	return prefix, nil
 }
 
 type RawData struct {

traefik/traefik_test.go

@@ -35,6 +35,7 @@ func Test_getPath(t *testing.T) {
 			got, err := getPath(tt.args.s)
 			if (err != nil) != tt.wantErr {
 				t.Errorf("getPath() error = %v, wantErr %v", err, tt.wantErr)
+
 				return
 			}
 			if got != tt.want {