EPMRPP-77977 || Code review fixes - 1

reportportal · Jul 1, 2022 · 0a3be9a · 0a3be9a
1 parent 75e3d5b
commit 0a3be9a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/app/src/common/css/variables/newColors.scss b/app/src/common/css/variables/newColors.scss
@@ -54,4 +54,4 @@ $COLOR--tag-value-text: #394db6;
 $COLOR--tag-value-background: #ced8fc;
 $COLOR--tag-key-text: #6f4599;
 $COLOR--tag-key-background: #dac3e6;
-$COLOR--grey-90: #e5e5e5;
+$COLOR--settings-menu-hover: #e5e5e5;
diff --git a/app/src/pages/inside/projectSettingsPageContainer/content/notifications/notifications.jsx b/app/src/pages/inside/projectSettingsPageContainer/content/notifications/notifications.jsx
@@ -172,7 +172,7 @@ export const Notifications = ({ setHeaderTitleNode }) => {
     }
 
     return () => setHeaderTitleNode(null);
-  });
+  }, [setHeaderTitleNode]);
 
   const onToggleHandler = (isEnabled, notification) => {
     trackEvent(

diff --git a/app/src/pages/inside/projectSettingsPageContainer/navMenu/navMenu.scss b/app/src/pages/inside/projectSettingsPageContainer/navMenu/navMenu.scss
@@ -33,7 +33,7 @@
   text-overflow: ellipsis;
 
   &:hover {
-    background-color: $COLOR--grey-90;
+    background-color: $COLOR--settings-menu-hover;
   }
 }