Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support UNTESTED test state #2537

Closed
wants to merge 1 commit into from
Closed

Conversation

odubaj
Copy link

@odubaj odubaj commented Dec 7, 2020

No description provided.

@odubaj odubaj changed the title Support manual test state Support UNTESTED test state Dec 12, 2020
@codecov-io
Copy link

Codecov Report

Merging #2537 (12e9c6e) into develop (d35d03f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2537      +/-   ##
===========================================
+ Coverage    55.64%   55.68%   +0.04%     
===========================================
  Files          172      172              
  Lines         3251     3254       +3     
  Branches       598      598              
===========================================
+ Hits          1809     1812       +3     
  Misses        1181     1181              
  Partials       261      261              
Impacted Files Coverage Δ
app/src/components/widgets/common/messages.js 100.00% <ø> (ø)
app/src/controllers/project/selectors.js 49.05% <ø> (ø)
app/src/common/constants/colors.js 100.00% <100.00%> (ø)
app/src/common/constants/launchStatuses.js 100.00% <100.00%> (ø)
app/src/common/constants/testStatuses.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d35d03f...12e9c6e. Read the comment docs.

@AmsterGet AmsterGet self-requested a review February 8, 2021 08:55
Copy link
Member

@AmsterGet AmsterGet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Can be merged after:

  • Returning the linter to the CI
  • Resolving conflicts
  • Backend implementation

Makefile Outdated Show resolved Hide resolved
@odubaj
Copy link
Author

odubaj commented Feb 8, 2021

Seems strange to me, I rebased my fork against current develop branch, then rebased UNTESTED commit according to your advices, but it does not seem to have updated this pull-request. fork to commit here: https://github.com/odubaj/service-ui/commits/develop

Maybe opening a new PR will be a solution ?

@odubaj
Copy link
Author

odubaj commented Feb 8, 2021

Seems to be some github API issue. Everything up-to-date now.

@AmsterGet AmsterGet self-requested a review February 8, 2021 21:09
@AmsterGet
Copy link
Member

@odubaj Could you please resolve conflicts with the target branch?

@odubaj
Copy link
Author

odubaj commented Apr 1, 2021

@odubaj Could you please resolve conflicts with the target branch?

Done

@chivekrodis
Copy link
Contributor

@odubaj Could you please update your fork to the latest, change target branch into untested_test and resolve conflicts if any?

@odubaj
Copy link
Author

odubaj commented Jul 16, 2021

Done, available in new PR:

#2768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants