-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support UNTESTED test state #2537
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2537 +/- ##
===========================================
+ Coverage 55.64% 55.68% +0.04%
===========================================
Files 172 172
Lines 3251 3254 +3
Branches 598 598
===========================================
+ Hits 1809 1812 +3
Misses 1181 1181
Partials 261 261
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Can be merged after:
- Returning the linter to the CI
- Resolving conflicts
- Backend implementation
app/src/pages/inside/dashboardItemPage/modals/common/widgets.jsx
Outdated
Show resolved
Hide resolved
Seems strange to me, I rebased my fork against current develop branch, then rebased UNTESTED commit according to your advices, but it does not seem to have updated this pull-request. fork to commit here: https://github.com/odubaj/service-ui/commits/develop Maybe opening a new PR will be a solution ? |
Seems to be some github API issue. Everything up-to-date now. |
@odubaj Could you please resolve conflicts with the target branch? |
Done |
@odubaj Could you please update your fork to the latest, change target branch into |
Done, available in new PR: |
No description provided.