Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPMRPP-75871 || Use plugin accessType to define public plugins #3055

Merged
merged 1 commit into from
Apr 5, 2022
Merged

EPMRPP-75871 || Use plugin accessType to define public plugins #3055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions app/src/components/extensionLoader/extensionLoader.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ const DEFAULT_EXTENSION_FILE_NAME = 'remoteEntity.js';

// TODO: Create a special error boundary for extension components
function ExtensionLoader({ extension, ...componentProps }) {
const { moduleName, scope, pluginName } = extension;
// TODO: use public/private endpoint to get files based on plugin type preferences (will be implemented in the scope of Sign Up plugin)
const url = URLS.pluginFile(pluginName, DEFAULT_EXTENSION_FILE_NAME);
const { moduleName, scope, pluginName, isPublic } = extension;
const url = isPublic
? URLS.pluginPublicFile(pluginName, DEFAULT_EXTENSION_FILE_NAME)
: URLS.pluginFile(pluginName, DEFAULT_EXTENSION_FILE_NAME);

const { failed, Component } = useFederatedComponent(scope, moduleName, url);

Expand Down
3 changes: 2 additions & 1 deletion app/src/controllers/plugins/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ export const REMOVE_PROJECT_INTEGRATION_SUCCESS = 'removeProjectIntegrationSucce

export const GLOBAL_INTEGRATIONS = 'globalIntegrations';
export const PROJECT_INTEGRATIONS = 'projectIntegrations';
export const PUBLIC_PLUGINS = 'publicPlugins';

export const SECRET_FIELDS_KEY = 'rp_secretFieldsToClear';

export const PUBLIC_PLUGINS = 'publicPlugins';
export const PUBLIC_PLUGIN_ACCESS_TYPE = 'public';
12 changes: 6 additions & 6 deletions app/src/controllers/plugins/uiExtensions/sagas.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { select, call, all, put } from 'redux-saga/effects';
import { URLS } from 'common/urls';
import { fetch } from 'common/utils/fetch';
import { activeProjectSelector } from 'controllers/user';
import { PUBLIC_PLUGINS } from 'controllers/plugins/constants';
import { PUBLIC_PLUGINS, PUBLIC_PLUGIN_ACCESS_TYPE } from 'controllers/plugins/constants';
import { COMMAND_GET_FILE, METADATA_FILE_KEY, MAIN_FILE_KEY } from './constants';
import { pluginsSelector, globalIntegrationsSelector, publicPluginsSelector } from '../selectors';
import { filterIntegrationsByName, isPluginSupportsCommonCommand } from '../utils';
Expand All @@ -13,8 +13,8 @@ import {
} from './actions';

export function* fetchExtensionsMetadata(action) {
const isPublic = action && action.meta.namespace === PUBLIC_PLUGINS;
const plugins = yield select(isPublic ? publicPluginsSelector : pluginsSelector);
const isPublicPluginNamespace = action && action.meta.namespace === PUBLIC_PLUGINS;
const plugins = yield select(isPublicPluginNamespace ? publicPluginsSelector : pluginsSelector);
const uiExtensionPlugins = plugins.filter(
(plugin) =>
plugin.enabled &&
Expand All @@ -30,11 +30,11 @@ export function* fetchExtensionsMetadata(action) {

// TODO: discuss with BE whether we can fetch plugins metadata via single API call
const calls = uiExtensionPlugins.map((plugin) => {
const isPluginPublic = plugin.details.accessType === PUBLIC_PLUGIN_ACCESS_TYPE;
const metadataFile = plugin.details.binaryData[METADATA_FILE_KEY];
// TODO: use public/private endpoint to get files based on plugin type (public/private)
return call(
fetch,
isPublic
isPluginPublic
? URLS.pluginPublicFile(plugin.name, metadataFile)
: URLS.pluginFile(plugin.name, metadataFile),
{
Expand All @@ -52,7 +52,7 @@ export function* fetchExtensionsMetadata(action) {
const metadataArray = results.map((metadata, index) => ({
...metadata,
pluginName: uiExtensionPlugins[index].name,
isPublic,
isPublic: uiExtensionPlugins[index].details.accessType === PUBLIC_PLUGIN_ACCESS_TYPE,
}));

yield put(fetchExtensionsMetadataSuccessAction(metadataArray));
Expand Down