Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-76491 || project settings header #3069

Merged
merged 4 commits into from
Apr 15, 2022

Conversation

chivekrodis
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #3069 (02903a9) into EPMRPP-76490-settings-navigation (0438b2c) will not change coverage.
The diff coverage is n/a.

@@                        Coverage Diff                        @@
##           EPMRPP-76490-settings-navigation    #3069   +/-   ##
=================================================================
  Coverage                             59.85%   59.85%           
=================================================================
  Files                                    75       75           
  Lines                                   802      802           
  Branches                                118      118           
=================================================================
  Hits                                    480      480           
  Misses                                  294      294           
  Partials                                 28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0438b2c...02903a9. Read the comment docs.

@chivekrodis chivekrodis force-pushed the EPMRPP-76490-settings-navigation branch 2 times, most recently from 7f68a6a to 11d8331 Compare April 15, 2022 12:42
@chivekrodis chivekrodis force-pushed the EPMRPP-76491-settings-header branch 2 times, most recently from c6b744e to 01bf2c2 Compare April 15, 2022 13:09
Copy link
Member

@AmsterGet AmsterGet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment about tabsConfig, now we don't have tabs. Please rename to smth like navConfig or pagesConfig or smth like that.

Base automatically changed from EPMRPP-76490-settings-navigation to develop April 15, 2022 13:32
@AmsterGet
Copy link
Member

Please resolve conflicts.

@AmsterGet AmsterGet merged commit 7da6ae5 into develop Apr 15, 2022
@AmsterGet AmsterGet deleted the EPMRPP-76491-settings-header branch April 15, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants