Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPMRPP-76676 || Logs error fix #3085

Merged
merged 8 commits into from
Apr 29, 2022
Merged

EPMRPP-76676 || Logs error fix #3085

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
49b1634
EPMRPP-76676 || Logs error fix
tr1ble Apr 28, 2022
77f66c2
EPMRPP-76676 || Code review fixes - 1
tr1ble Apr 28, 2022
61a1ee5
EPMRPP-76676 || Code review fixes - 2
tr1ble Apr 29, 2022
65132dc
EPMRPP-76676 || Code review fixes - 3
tr1ble Apr 29, 2022
98dd814
EPMRPP-76676 || Code review fixes - 4
tr1ble Apr 29, 2022
fa27b37
EPMRPP-76676 || Code review fixes - 5
tr1ble Apr 29, 2022
8ad2e02
EPMRPP-76676 || Code review fixes - 6
tr1ble Apr 29, 2022
e427024
EPMRPP-76676 || Code review fixes - 7
tr1ble Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions app/src/components/integrations/elements/pluginIcon/pluginIcon.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,17 @@ import { filterIntegrationsByName, isPluginSupportsCommonCommand } from 'control
import { PLUGIN_DEFAULT_IMAGE, PLUGIN_IMAGES_MAP } from 'components/integrations/constants';
import { Image } from 'components/main/image';

const PUBLIC_ACCESS_TYPE = 'public';
const FILE_KEY = 'plugin-icon.svg';

export const PluginIcon = ({ pluginData, className, ...rest }) => {
const { details, name } = pluginData;
const isDynamicIconAvailable = details && details.binaryData && details.binaryData.icon;
const projectId = useSelector(activeProjectSelector);
const globalIntegrations = useSelector(globalIntegrationsSelector);

const isPublic = details && details.accessType === PUBLIC_ACCESS_TYPE;
AmsterGet marked this conversation as resolved.
Show resolved Hide resolved

const calculateIconSrc = () => {
if (isDynamicIconAvailable) {
const isCommonCommandSupported = isPluginSupportsCommonCommand(pluginData, COMMAND_GET_FILE);
Expand All @@ -44,7 +49,9 @@ export const PluginIcon = ({ pluginData, className, ...rest }) => {
return null;
}

return URLS.projectIntegrationByIdCommand(projectId, integration.id, COMMAND_GET_FILE);
return isPublic
? URLS.pluginPublicFile(integration.name, FILE_KEY)
AmsterGet marked this conversation as resolved.
Show resolved Hide resolved
: URLS.projectIntegrationByIdCommand(projectId, integration.id, COMMAND_GET_FILE);
}
AmsterGet marked this conversation as resolved.
Show resolved Hide resolved

return PLUGIN_IMAGES_MAP[name] || PLUGIN_DEFAULT_IMAGE;
Expand All @@ -56,7 +63,7 @@ export const PluginIcon = ({ pluginData, className, ...rest }) => {
src={calculateIconSrc()}
fallback={PLUGIN_DEFAULT_IMAGE}
isStatic={!isDynamicIconAvailable}
requestParams={{ method: 'PUT', data: { fileKey: 'icon' } }}
requestParams={isPublic ? { method: 'GET' } : { method: 'PUT', data: { fileKey: 'icon' } }}
preloaderColor="charcoal"
className={className}
{...rest}
Expand Down