Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase number of chars in description of a launch to 4096 #3109

Closed
wants to merge 1 commit into from
Closed

Increase number of chars in description of a launch to 4096 #3109

wants to merge 1 commit into from

Conversation

msisam
Copy link

@msisam msisam commented May 23, 2022

We use the launch description to allow our users to have that information presented within the launch description such as links, artifacts, OKR Results.
But the limit of 1024 chars trims most of the links and data from there.

Example:
Screen Shot 2022-05-26 at 20 03 10

We use the launch description to allow our users to have that information presented within the launch description such as links, artifacts, OKR Results. 
But the limit of 1024 chars trims most of the links and data from there.
@AmsterGet
Copy link
Member

Hello @msisam !
Thanks for your PR!
We need to discuss your proposal with the team and BA to see all options regarding this restriction.
Stay in touch!
@evjlobanova and @VolhaKarenko what do you think about this improvement?

@msisam
Copy link
Author

msisam commented May 23, 2022

@AmsterGet Thanks!
I also checked in the Schema it looks like it's not limited there
https://github.com/reportportal/migrations/blob/324e18968b32f3b16a146b6f80a1e6fb609ac054/migrations/1_initialize_schema.up.sql#L387

This will be a really big help for us as we will be able to complete the visibility for all related information of a launch
Please Let me know what you think!

@VolhaKarenko
Copy link
Contributor

VolhaKarenko commented May 24, 2022

@VeranikaRymzha @Kozovskaya please take a look

@msisam
Copy link
Author

msisam commented May 26, 2022

Hey,
Would love to get any response regarding this please
I guess it's not a big change so maybe we can push this forward?

Thanks!

@VeranikaRymzha
Copy link

Hello @msisam,
I'm sorry for the late reply.
We'll discuss this issue with the team next week and come back to you with the updates.

@msisam
Copy link
Author

msisam commented May 27, 2022

Thanks @VeranikaRymzha

@VeranikaRymzha
Copy link

Hello @msisam,
Just to keep you updated.
The task is in progress. At the moment the team investigates the question so as to find the optimal number of chars from backend, frontend and performance perspective.
I'll keep you posted.

@msisam
Copy link
Author

msisam commented Jun 16, 2022

Hey @VeranikaRymzha
Any chance you can update the current status of this?

thanks!

@VeranikaRymzha
Copy link

Hey @msisam,
Thank you for your patience.

Following the results of the investigation stage (performance tests results + design team recommendations) we won't be able to increase the limit for the number of chars in launch description to 4096. I'm sorry.

However, we plan to increase it up to 2048 which won't affect negatively performance and user performance, and hopefully will benefit ReportPortal users.
The development team is working on this task at the moment.

@msisam
Copy link
Author

msisam commented Aug 25, 2022

Hi @VeranikaRymzha
any update on this one?
I'm trying to find the change in master or other branches but still can't see it.

Thanks

@VeranikaRymzha
Copy link

Hi @msisam,
Sorry for my late reply.

The adjustments have been implemented. But they will be released in Version 5.7.3 (we plan to have it in September-October).

Important moment: we were able to increase the limit for the number of chars in launch description to 2048 only due to Performance and UX limitations we have. Please, let me know if there are any other questions.

@msisam msisam closed this by deleting the head repository Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants