Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-78274 || Upgrade react version to 17th #3199

Merged
merged 8 commits into from
Dec 26, 2022
Merged

Conversation

Vadim73i
Copy link
Contributor

No description provided.

Copy link
Contributor

@chivekrodis chivekrodis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR contains breaking changes
pipeline failed
tooltips(popper-js) are have wrong behaviour doesn't work or appear in the wrong place(f.e login page versions, select project, history)
upload btn broken
Looks like dashboards work inappropriate way(appearance, creating)
a lot of errors in the console

Copy link
Contributor

@chivekrodis chivekrodis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts
Have no possibility create Launch statistics chart
Edit Launch statistics chart leads to crash
Charts have strange behavior: widgets collapse in width after 1083px
Filter by start time on the launch page leads to crash app

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Merging #3199 (1d4df04) into develop (639ff17) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #3199   +/-   ##
========================================
  Coverage    61.92%   61.92%           
========================================
  Files           74       74           
  Lines          801      801           
  Branches       121      121           
========================================
  Hits           496      496           
  Misses         278      278           
  Partials        27       27           
Impacted Files Coverage Δ
app/src/common/constants/timeDateFormat.js 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AmsterGet
Copy link
Member

Also please resolve conflicts.

@AmsterGet AmsterGet merged commit eff644b into develop Dec 26, 2022
@AmsterGet AmsterGet deleted the EPMRPP-78274_react_17 branch December 26, 2022 14:39
AmsterGet pushed a commit that referenced this pull request Jul 24, 2023
* EPMRPP-78274 || Upgrade react version to 17th

* EPMRPP-78274 || code review fixes - 1

* EPMRPP-78274 || code review fixes - 2

* EPMRPP-78274 || linebreak fix

* EPMRPP-78274 || code review fixes - 3

* intl.formatMessage with tags fix

* apostrophe fix

* formatMessage fix
Bam6ycha pushed a commit that referenced this pull request Aug 25, 2023
* EPMRPP-78274 || Upgrade react version to 17th

* EPMRPP-78274 || code review fixes - 1

* EPMRPP-78274 || code review fixes - 2

* EPMRPP-78274 || linebreak fix

* EPMRPP-78274 || code review fixes - 3

* intl.formatMessage with tags fix

* apostrophe fix

* formatMessage fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants