Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPMRPP-78275 || refactor attribute with control #3212

Merged
merged 2 commits into from
Aug 8, 2022
Merged

EPMRPP-78275 || refactor attribute with control #3212

merged 2 commits into from
Aug 8, 2022

Conversation

chivekrodis
Copy link
Contributor

@chivekrodis chivekrodis commented Aug 4, 2022 •
edited
Loading

No description provided.

@chivekrodis chivekrodis force-pushed the EPMRPP-78275-refactor_attribute_with_control branch from 0bf1652 to 91b022e Compare August 4, 2022 10:08
@chivekrodis chivekrodis changed the title EPMRPP-78275 || refactor attribute with control DNM EPMRPP-78275 || refactor attribute with control Aug 4, 2022
@chivekrodis chivekrodis force-pushed the EPMRPP-78275-refactor_attribute_with_control branch 4 times, most recently from 4d66e02 to 100e8b8 Compare August 5, 2022 11:50
@chivekrodis chivekrodis changed the title DNM EPMRPP-78275 || refactor attribute with control EPMRPP-78275 || refactor attribute with control Aug 5, 2022
AmsterGet
AmsterGet requested changes Aug 8, 2022
View reviewed changes
Copy link
Member

@AmsterGet AmsterGet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The common suggestion.
When the form engine is separated from fields it gives some benefits:

  • Easy migration to the new form engine
  • Low coupling
  • Inversion of control (component's users will decide by themselves what they need to use)

app/src/componentLibrary/attributeList/editableAttributeList.jsx Show resolved Hide resolved
app/src/components/containers/attributeListContainer/attributeListContainer.jsx Outdated Show resolved Hide resolved
app/src/components/containers/attributeListContainer/attributeListContainer.jsx Outdated Show resolved Hide resolved
app/src/componentLibrary/attributeList/editableAttributeList.jsx Outdated Show resolved Hide resolved
@chivekrodis chivekrodis force-pushed the EPMRPP-78275-refactor_attribute_with_control branch from 3ed30be to 77297f8 Compare August 8, 2022 16:19
@chivekrodis chivekrodis force-pushed the EPMRPP-78275-refactor_attribute_with_control branch from 77297f8 to 2dfea0c Compare August 8, 2022 16:22
@AmsterGet AmsterGet merged commit 96b4fa1 into develop Aug 8, 2022
@AmsterGet AmsterGet deleted the EPMRPP-78275-refactor_attribute_with_control branch August 8, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmsterGet AmsterGet AmsterGet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chivekrodis @AmsterGet