Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-79223 || add max-width and change onClick target integration item #3363

Conversation

KrasovskyAlexander
Copy link

@KrasovskyAlexander KrasovskyAlexander commented Dec 20, 2022

EPMRPP-79223
AND
EPMRPP-79899

Before:
image


After:
Screenshot_161


@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Merging #3363 (b011fc1) into develop (ef57608) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3363   +/-   ##
========================================
  Coverage    61.92%   61.92%           
========================================
  Files           74       74           
  Lines          801      801           
  Branches       121      121           
========================================
  Hits           496      496           
  Misses         278      278           
  Partials        27       27           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Bam6ycha
Copy link
Contributor

I think that we need to change the state of an arrow when we hover over the whole Integration item to the hover state.
If you look more carefully now when we hover over the arrow it changes its color.
I think that we need to implement changing the color of the arrow when we hover over the whole integration item.

@@ -79,7 +79,7 @@ export const Integrations = () => {
};

return (
<>
<div style={{ maxWidth: '1200px', margin: '0 auto' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as in #3361.
Follow the recommendations that @AmsterGet provided there.

@@ -24,4 +24,6 @@ $Z-INDEX-PAGE-CONTAINER-HEADER: 2;

.content {
padding: 33px 32px 60px;
max-width: 1200px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great solution, but it breaks styles in the Demo Data tab, Analyzer tab, General tab. Take a closer look at these tabs and compare the styles to the design system.
Also, note that there is an extra margin in the integrations. Because of them, integrations are not centered.
2022-12-26_14h57_47

@AmsterGet AmsterGet merged commit ff7ef46 into develop Dec 27, 2022
@AmsterGet AmsterGet deleted the EMPRPP-79223_intergration-tab-has-different-style-from-mockup branch December 27, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants