Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-79270 || remove placeholder if recipient added #3366

Merged

Conversation

KrasovskyAlexander
Copy link

EPMRPP-79270

Before:
image


After:
Screenshot_163


@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2022

Codecov Report

Merging #3366 (7b16568) into develop (ef57608) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3366   +/-   ##
========================================
  Coverage    61.92%   61.92%           
========================================
  Files           74       74           
  Lines          801      801           
  Branches       121      121           
========================================
  Hits           496      496           
  Misses         278      278           
  Partials        27       27           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AmsterGet AmsterGet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to hide the placeholder for launch names as well? Please confirm with QA team.

image

If yes, I suppose that better to make a fix inside of AsyncMultipleAutocomplete to keep components behavior the same.

@KrasovskyAlexander
Copy link
Author

@AmsterGet you correct!
Screenshot_166
fixed ✅

@AmsterGet AmsterGet merged commit 8f44797 into develop Dec 27, 2022
@AmsterGet AmsterGet deleted the EPMRPP-79270_placeholder-remains-when-the-recipient-is-added branch December 27, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants