EPMRPP-77501 || sorted integrations after add new item #3371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3371 +/- ##
========================================
Coverage 61.92% 61.92%
========================================
Files 74 74
Lines 801 801
Branches 121 121
========================================
Hits 496 496
Misses 278 278
Partials 27 27 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Bam6ycha
requested changes
Jan 4, 2023
...ntegrations/integrationsList/integrationInfo/integrationCollection/integrationCollection.jsx
Outdated
Show resolved
Hide resolved
AmsterGet
requested changes
Jan 4, 2023
There was a problem hiding this comment.
@KrasovskyAlexander @Bam6ycha
As I see in the previous task (EPMRPP-67609), the sorting was done on the BE side, so it will be redundant to sort integrations again on UI.
I would suggest to just add the new integration to the start of the list at src/controllers/plugins/reducer.js addIntegration function.
Bam6ycha
reviewed
Jan 5, 2023
...ntegrations/integrationsList/integrationInfo/integrationCollection/integrationCollection.jsx
Outdated
Show resolved
Hide resolved
Bam6ycha
approved these changes
Jan 5, 2023
AmsterGet
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EPMRPP-77501
sorted integrations by creationDate after add new item