Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-81141 || hidden manage buttons when user without manage permissions #3377

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

KrasovskyAlexander
Copy link

EPMRPP-81141
hidden manage buttons when user without manage permissions

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

Merging #3377 (4cfb519) into develop (bb1142e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3377   +/-   ##
========================================
  Coverage    61.92%   61.92%           
========================================
  Files           74       74           
  Lines          801      801           
  Branches       121      121           
========================================
  Hits           496      496           
  Misses         278      278           
  Partials        27       27           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

{Parser(PencilIcon)}
</button>
)}
{this.props.userProjectRole === PROJECT_MANAGER && (
Copy link
Member

@AmsterGet AmsterGet Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the common permissions engine - canUpdateSettings from 'common/utils/permissions'.
Usage example - src/pages/common/settingsPage/autoAnalysisTab/autoAnalysisTab.jsx.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed ✓

@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AmsterGet AmsterGet merged commit 25acb6c into develop Jan 20, 2023
@AmsterGet AmsterGet deleted the EPMRPP-81141_hidden-manage-buttons-for-member branch January 20, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants