WIP: If account-level config is changed trigger update all #179
Conversation
|
Ah, nice. I've just started using Settings Bot, and noticed that none of my changes to github.com/ORG/.github were being propagated to my other repos. |
|
sorry that it has taken a while to take a dee look at this, but i do really like the approach to this. the alternative of updating the other repos for all commits to the default branch seemed like overkill to me, so i like that this approach is triggered by an actual change to the account-level config instead. this is a big change to the behavior of this system, so i do want to be careful with getting this integrated. it is also high value, so i definitely want to solve this need. |
travi
changed the title
travi
changed the title
|
@jay-oswald sorry for the delays, but this is still high on the priority list. there are a few items that i am working to get completed ahead of this in order to make enabling this type of functionality in a safe way. since this is a complex feature, it has the potential to cause problems that we want to avoid. it has been a little difficult lately to find time to focus on moving this forward safely, but please know that it is still planned to be an upcoming feature |
|
Any support needed to help move this through? |
|
as mentioned in my recent comment, this is high on the priority list, but needs to be implemented carefully. it is a difficult one to get done through community contributions. please know that it is planned once some other pieces can come together. |
| const config = await context.config('settings.yml', {}, { arrayMerge: mergeArrayByName }) | ||
| return Settings.sync(context.github, context.repo(), config) | ||
| await onPush(context) | ||
| if (repositoryName === '.github') { |
There was a problem hiding this comment.
Do you think we could make this configurable in case I don't want to name my .github repository ".github"? The main reason for that is that I have a master repo which has submodules with all the repos in the org. I currently named my "base" repo template, but I'm not married to that. However, I can't name it ".github", because then I can't have a submodule for it in the main stack repo, at least not have it named the same way as the .github repo itself. I could have a submodule "template" that points at the repo ".github", but it would be anomalous compared to everything else.
There was a problem hiding this comment.
these are the types of details that make this implementation complex. thank you for raising this so that we can consider it. i wasnt personally aware that probot-config supported extending config from other repos than .github, but if that is supported there, it probably makes sense to find a way to enable when this goes out.
would you mind capturing those thoughts in #95 in case this PR ends up not being the way we move this effort forward?
|
Could this be possibly moved forward? |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
Fixes #95
WIP as I the implementation is open for discussion.
flow: