Close iterable after iteration #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the response iterator has a `.close()` method call it after iteration is complete. This is required by the WSGI specification, details can be found here: https://www.python.org/dev/peps/pep-0333/#specification-details
Seems to be required for later versions of pip: travis-ci/travis-ci#6727
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the response iterator has a
.close()method call it after iterationis complete.
This is required by the WSGI specification, details can be found here:
https://www.python.org/dev/peps/pep-0333/#specification-details
Same idea as #6 but I moved the
.close()call inside the outer try/except. This means the iterable will be closed() before the transaction is aborted on error. I'm not 100% sure this maintains the requirements for aborting, but this works well to solve my problem using WSGI middlewares that rely onclose()being called.