Reduce target framework of Reqnroll to netstandard2.0 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atformCompatibility
This reverts commit 6e08680.
gasparnagy
force-pushed
the
simplify-target-fw
branch
from
b02c5b8 to
ae7c86a
Compare
gasparnagy
changed the title
gasparnagy
force-pushed
the
simplify-target-fw
branch
from
6399a98 to
81d203c
Compare
gasparnagy
force-pushed
the
simplify-target-fw
branch
from
c3e0608 to
9ac1ca9
Compare
gasparnagy
changed the title
|
I did some extra exploratory testing and it seems to work. |
gasparnagy
added a commit
that referenced
this pull request
May 22, 2024
…ons-dependencyinjection-plugin * origin/main: (21 commits) Fix #56 autofac ambiguous stepdef and hook required #127 issue (#139) Reduce target framework of Reqnroll to netstandard2.0 (#130) Fix StackOverflowException when using [StepArgumentTransformation] with same input and output type (#136) MsTest: Replace DelayedFixtureTearDown special case with ClassCleanupBehavior.EndOfClass (#128) Temporarily disabled tests until #132 is resolved Add NUnit & xUnit core tests to portability suite Capture ExecutionContext after every binding invoke (#126) small improvement in CodeDomHelper to be able to chain async calls fix method name sources in UnitTestFeatureGenerator External data plugin, support for JSON files (#118) UnitTests: Check if SDK version is installed and if not ignore the test (#109) Fix 111 ignore attr not inherited from rule (#113) Update README.md (#110) Fix 81 - modified CucumberExpressionParameterTypeRegistry to handle multiple custom types used as cucumber expressions when those types share the same short name. (#104) Update index.md Simplify test project targets (#105) Make SystemTests temp folder configurable and use NUGET_PACKAGES env var to override global NuGet folder Fleshing out Generation System Tests (2) (#99) Fix for 81 - Cucumber Expression using Enums errors when two enums exist with the same short name (#100) Include BoDi to Reqnroll package (#91) (#95) ... # Conflicts: # Reqnroll.sln # Tests/Reqnroll.PluginTests/Reqnroll.PluginTests.csproj
gasparnagy
added a commit
that referenced
this pull request
May 22, 2024
…hread-container * origin/main: Extract cucumber expression detection heuristic to an interface fix test artifact folder calculation Restructure solution folders (#141) cleanup CHANGELOG.md ignore generated file remove generated file bump version Add Microsoft.Extensions.DependencyInjection integration plugin (#94) Fix #56 autofac ambiguous stepdef and hook required #127 issue (#139) Reduce target framework of Reqnroll to netstandard2.0 (#130) Fix StackOverflowException when using [StepArgumentTransformation] with same input and output type (#136) # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the target framework of the main Reqnroll package and many other packages to "netstandard2.0". This includes the generator project.
Related discussion: https://github.com/orgs/reqnroll/discussions/31
Besides a simpler compilation and code management, this also supports creating Reqnroll packages using single target (
netstandard2.0) projects. Multi-target projects are still allowed.All supported frameworks (.NET 4.6.2+, .NET 6.0, .NET 7.0, .NET 8.0) support .NET Standard 2.0, so this is not a breaking change.
The
Reqnroll.Tools.MsBuild.Generationproject is still multi-target, becausemsbuild.exeand Visual Studio still compiles the projects using .NET Framework (.NET 4.8) and the netstandard2.0 version of the CodeDom dependency is not compatible with .NET 4.8 (we need the copy of the .NET Framework version of the CodeDom assembly). As theReqnroll.Tools.MsBuild.Generationis a leaf project (no one has a project reference to it), this does not generate further needs for multi-targeting.Finally the following projects have multi-target:
Reqnroll.Tools.MsBuild.Generation- as described aboveReqnroll.Verify.ReqnrollPlugin- because theVerifydependency has no netstandard2.0 supportReqnroll.SpecFlowCompatibility.ReqnrollPluginand the related generator project - because we support app.config handling only for .NET FrameworkThe
System.Runtime.Loaderpackage we use for plugin assembly loading on modern .NET versions is not compatible with .NET Framework and we have to fall back toAssembly.LoadFrom. This was done so far with an#ifpragma, now it is abstracted away with theIPluginAssemblyLoaderinterface and the appropriate implementation is registered (PlatformHelper.RegisterPluginAssemblyLoader).Checklist: