-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gherkin to v28 #205
Conversation
Noting that I need to keep an eye on this for probable knock on in #200 |
@Code-Grump No, I don't think so. |
@Code-Grump can you have a quick look and approve if ok? |
Can do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked through the Gherkin release notes and there doesn't seem to be any additions that we'd need to make code-changes for, so this PR is pleasingly minimal.
The simplifications to package references look good.
🤔 What's changed?
The Gherkin dependency has been updated to v28 (from v19)
⚡️ What's your motivation?
There are some changes (mainly related to keyword translations). See https://github.com/cucumber/gherkin/blob/main/CHANGELOG.md
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.