Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gherkin to v28 #205

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Update Gherkin to v28 #205

merged 4 commits into from
Jul 12, 2024

Conversation

gasparnagy
Copy link
Contributor

🤔 What's changed?

The Gherkin dependency has been updated to v28 (from v19)

⚡️ What's your motivation?

There are some changes (mainly related to keyword translations). See https://github.com/cucumber/gherkin/blob/main/CHANGELOG.md

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

@Code-Grump
Copy link
Contributor

Noting that I need to keep an eye on this for probable knock on in #200

@gasparnagy
Copy link
Contributor Author

@Code-Grump No, I don't think so.

@gasparnagy gasparnagy marked this pull request as ready for review July 12, 2024 11:43
@gasparnagy gasparnagy requested a review from Code-Grump July 12, 2024 11:44
@gasparnagy
Copy link
Contributor Author

@Code-Grump can you have a quick look and approve if ok?

@Code-Grump
Copy link
Contributor

@Code-Grump can you have a quick look and approve if ok?

Can do.

Copy link
Contributor

@Code-Grump Code-Grump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked through the Gherkin release notes and there doesn't seem to be any additions that we'd need to make code-changes for, so this PR is pleasingly minimal.

The simplifications to package references look good.

@gasparnagy gasparnagy merged commit d7e3161 into main Jul 12, 2024
4 checks passed
@gasparnagy gasparnagy deleted the upgrade-to-gherkin28 branch July 12, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants