Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tags containing special characters #2748

Merged
merged 1 commit into from
Dec 13, 2020

Conversation

mkalam-alami
Copy link
Contributor

@mkalam-alami mkalam-alami commented Nov 23, 2020

See #2743

Manual tests

Initial state : Create a "Home" page having two tags "hé hé hé" and "hello world". Navigate to view that page.

  • When clicking on "hé hé hé", then it preselects the matching tag and displays "Home" among the results
  • When clicking on "hé hé hé", and refreshing the page, then it returns identical results
  • When clicking on "hé hé hé", and interacting with tags on the sidebar, then it updates the search results and address bar expectedly
  • When going to the tags page, and clicking both tags "hé hé hé" and "hello world", and refreshing the page, then it still returns "Home" among the results

@mkalam-alami mkalam-alami changed the title Support tags containing special characters, closes #2743 Support tags containing special characters Nov 23, 2020
@NGPixel NGPixel merged commit b5af931 into requarks:dev Dec 13, 2020
jionggyu pushed a commit to jionggyu/wiki-2.5.302-patch that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants