Fix S3 copyObject usage - Missing bucket name #3745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGPixel
requested changes
Mar 23, 2021
NGPixel
requested changes
Mar 23, 2021
NGPixel
approved these changes
Mar 23, 2021
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
* Fix copyObject usage: supply bucket name * No semicolon * Assign empty string on initialization * Remove empty line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, upon moving/renaming files in wiki with AWS S3 storage setup, we get
Access Denied/Invalid object keyerrors from AWS.Solution
copyObjectmethod requires theCopySourcefield to supply the bucket name in the path.bucketNametoCopySourcefields.Let me know if this change is OK. I can make any change necessary to follow the repo's guidance.