feat(helm): adding liveness and readiness probes customizations #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGPixel
approved these changes
Jun 24, 2021
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
…arks#4116) * feat(helm): adding liveness and readiness probes customizations * chore(helm): bump chart version to 2.2.0 ***NO_CI***
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
It adds the ability to completely customize the liveness probe and readiness probe of the wikijs deployment in the helm chart.
The actual configuration DOES NOT change the probes defined before : users who do not care about this change won't notice anything.
Why this PR ?
I opened this PR because when I deployed wikijs via helm, after install the pod was crashlooping because it was too slow to start, and the probe keep restarting it, so I looked for more customizations of the probe and I got none, so I decided to make it myself and share it.
Where should the reviewer start ?
The two files changed are the deployment of wikijs : dev/helm/templates/deployment.yaml and the default values file in dev/helm/values.yaml
Tests
Using
helm template .renders the same deployment as before the change, so I think it does not break anything.Step to reproduce :
helm template test-release . > ~/.test-basehelm template test-release . > ~/.test-forkdiff ~/.test-base ~/.test-forkAnything else ?
Should I add an option to remove probes ?