[Fix] List paragraphs inline 100%, image into lists #6273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes many assumptions that are incorrect.
|
|
Does not apply to all, only for lists first paragraph, that actually contains the text. Adding a css that changes this paragraph when next paragraph contains an image, might fail if there are nested lists or other text, so with this, can help in this situation. I must admit that images changes the sizes a little bit if using =%x, but I tested this change and using this parameter, and works just fine.
|
NGPixel
approved these changes
Mar 18, 2023
davidflypei
pushed a commit
to davidflypei/wiki
that referenced
this pull request
Jun 13, 2023
* Adds width 100% for ol paragraph --------- Co-authored-by: Nicolas Giard <github@ngpixel.com>
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
* Adds width 100% for ol paragraph --------- Co-authored-by: Nicolas Giard <github@ngpixel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Editing in a private wiki, I try to use images to be part of a list, the issue is that those got aligned with the text, so I tested with the css to fix it. I also thought to change it with
display:block;, but if there's a reason to use inline-block for this, this change still will respect that and fix this issue. I include this tests images.Before:
After:
