Style guide #34
Merged
Style guide #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add folders and files to begin work on Astrum style guide.
Change the favicon image from the Astrum default to the Request Yo Racks logo.
rgreinho
requested changes
Mar 5, 2018
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "path": "./public/pattern-library" | |||
| } | |||
There was a problem hiding this comment.
Add a new line at the end of file.
public/pattern-library/data.json
Outdated
| @@ -0,0 +1,128 @@ | |||
| { | |||
| "project_logo": null, | |||
| "project_favicon": "ryr_logo.png", | |||
There was a problem hiding this comment.
I think the logo should also be set.
There was a problem hiding this comment.
I set the logo as the same image but I'm thinking we should change the favicon to the logo without the Request Yo Racks on the bottom.
public/pattern-library/data.json
Outdated
| "project_logo": null, | ||
| "project_favicon": "ryr_logo.png", | ||
| "project_name": "Request Yo Racks", | ||
| "project_url": null, |
There was a problem hiding this comment.
You can put the github url until we decide to publish something: http://request-yo-racks.github.io/.
rgreinho
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a Astrum style guide with color, typography, navigation and text input components.
Motivation and Context
To add a consistent style to the project. This addresses the issue:
#8
How Has This Been Tested?
Screenshots:
Types of changes
Checklist:
Fixes: https://github.com/request-yo-racks/web/8