Skip to content

Commit

Permalink
Merge branch 'master' into fixToughCookieDep
Browse files Browse the repository at this point in the history
  • Loading branch information
analog-nico authored Feb 14, 2019
2 parents 1457338 + 131abd7 commit 488947b
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 3 deletions.
4 changes: 4 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ matrix:
env: V_REQUEST=latest
- node_js: "6"
env: V_REQUEST=latest
- node_js: "8"
env: V_REQUEST=latest
- node_js: "10"
env: V_REQUEST=latest

before_install:
- npm install tough-cookie
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ Consider Request-Promise being:
- Plus some methods on a request call object:
- `rp(...).then(...)` or e.g. `rp.post(...).then(...)` which turn `rp(...)` and `rp.post(...)` into promises
- `rp(...).catch(...)` or e.g. `rp.del(...).catch(...)` which is the same method as provided by Bluebird promises
- Errors that the `request` library would pass to the callback are wrapped by `request-promise` and then passed to the catch handler. See [code example](https://github.com/request/request-promise#thenonfulfilled-onrejected) below.
- `rp(...).finally(...)` or e.g. `rp.put(...).finally(...)` which is the same method as provided by Bluebird promises
- `rp(...).cancel()` or e.g. `rp.get(...).cancel()` which cancels the request
- `rp(...).promise()` or e.g. `rp.head(...).promise()` which returns the underlying promise so you can access the full [Bluebird API](https://github.com/petkaantonov/bluebird/blob/master/API.md)
Expand Down
2 changes: 1 addition & 1 deletion lib/rp.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ try {
/* istanbul ignore next */
var EOL = require('os').EOL;
/* istanbul ignore next */
console.error(EOL + '###' + EOL + '### The "request" library is not installed automatically anymore.' + EOL + '### But required by "request-promise".' + EOL + '###' + EOL + '### npm install request --save' + EOL + '###' + EOL);
console.error(EOL + '###' + EOL + '### The "request" library is not installed automatically anymore.' + EOL + '### But is a dependency of "request-promise".' + EOL + '### Please install it with:' + EOL + '### npm install request --save' + EOL + '###' + EOL);
/* istanbul ignore next */
throw err;
}
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
"dependencies": {
"request-promise-core": "1.1.1",
"bluebird": "^3.5.0",
"stealthy-require": "^1.1.0",
"tough-cookie": "^2.5.0"
"stealthy-require": "^1.1.1",
"tough-cookie": "~2.3.3"
},
"peerDependencies": {
"request": "^2.34"
Expand Down

0 comments on commit 488947b

Please sign in to comment.