-
Notifications
You must be signed in to change notification settings - Fork 102
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make certain that responses always pass through handle_other() to provide mutual authentication before returning them to the user.
- Loading branch information
Showing
2 changed files
with
5 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -251,7 +251,7 @@ def handle_response(self, response, **kwargs): | |
if response.status_code == 401: | ||
_r = self.handle_401(response, **kwargs) | ||
log.debug("handle_response(): returning {0}".format(_r)) | ||
return _r | ||
return self.handle_response(_r, **kwargs) | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
sigmavirus24
Contributor
|
||
else: | ||
_r = self.handle_other(response) | ||
log.debug("handle_response(): returning {0}".format(_r)) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem of this is if handle_401 returns 401 again (in case of GSS api error), then you got infinite loop.