editor: fix hidden field with value from the model

Some fields containing values given with the input model should be visible
after the editor initialization. This is not the case with a recent version of
ngx formly. This is due to the use of bad hack `setTimeout` at several
places in the code. As ngx formly made the think cleaner these hacks have
been removed.

* Cleans hidden field list at the component destruction instead of
initialization.
* Reloads the JSONSchema once the model has changed.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>

projects/rero/ng-core/src/lib/record/editor/add-field-editor/add-field-editor.component.ts

@@ -57,8 +57,7 @@ export class AddFieldEditorComponent implements OnInit, OnDestroy {
     private _translateService: TranslateService
   ) {
     this.hiddenFields$ = this._editorService.hiddenFields$;
-    this._subscribers.push(
-      this.hiddenFields$.subscribe(fields => this.typeaheadFields = fields));
+
     this.typeaheadFields$ = new Observable((observer: Subscriber<string>) => {
       // Runs on every search
       observer.next(this.value);
@@ -73,6 +72,8 @@ export class AddFieldEditorComponent implements OnInit, OnDestroy {
    */
   ngOnDestroy() {
     this._subscribers.forEach(s => s.unsubscribe());
+    // avoid duplicate when switching between page
+    this._editorService.clearHiddenFields();
   }
 
   /**
@@ -105,8 +106,9 @@ export class AddFieldEditorComponent implements OnInit, OnDestroy {
    * Component init
    */
   ngOnInit() {
-    // avoid duplicate when switching between page
-    this._editorService.clearHiddenFields();
+    this._subscribers.push(
+      this.hiddenFields$.subscribe(fields => this.typeaheadFields = fields)
+    );
   }
 
   /**

projects/rero/ng-core/src/lib/record/editor/array-type/array-type.component.ts

@@ -47,7 +47,7 @@ export class ArrayTypeComponent extends FieldArrayType implements OnInit {
     this.isChildrenObject = this.field.fieldArray.type === 'object';
     this.isChildrenArray = this.field.fieldArray.type === 'array';
 
-    // reset the number of elements in the array when the array id hidden
+    // reset the number of elements in the array when the array is hidden
     this.field.options.fieldChanges.subscribe(changes => {
       const minItems = this.field.templateOptions.minItems ? this.field.templateOptions.minItems : 0;
       if (
@@ -62,6 +62,7 @@ export class ArrayTypeComponent extends FieldArrayType implements OnInit {
         const numberOfItemsToRemove = this.field.fieldGroup.length - minItems;
         // remove the extra elements
         // force removing the elements in the next event loop else this cause errors when removing multiple values
+        // TODO: try to remove this hack
         setTimeout(() => {
           for (let i = 0; i < numberOfItemsToRemove; i++) {
             this.remove(0);

projects/rero/ng-core/src/lib/record/editor/editor.component.ts

@@ -117,8 +117,13 @@ export class EditorComponent implements OnInit, OnChanges, OnDestroy {
    * @param changes: the changed properties
    */
   ngOnChanges(changes: SimpleChanges): void {
-    if (changes.model && !changes.model.isFirstChange) { // Model has changed
+    if (changes.model && !changes.model.isFirstChange()) { // Model has changed
       this._setModel(changes.model.currentValue);
+      // needed to select the right value for existing data in the multi select
+      // components such as oneOf
+      if (this.schema) {
+        this.setSchema(this.schema);
+      }
     }
   }
 
@@ -287,6 +292,8 @@ export class EditorComponent implements OnInit, OnChanges, OnDestroy {
     // reorder all object properties
     this.schema = orderedJsonSchema(schema);
     this.options = {};
+    // remove hidden field list in case of a previous setSchema call
+    this._editorService.clearHiddenFields();
 
     // form configuration
     const fields = [
@@ -359,16 +366,12 @@ export class EditorComponent implements OnInit, OnChanges, OnDestroy {
     model = removeEmptyValues(model);
     const modelEmpty = isEmpty(model);
     if (!modelEmpty && (field.hide === true)) {
-      setTimeout(() => {
         field.hide = false;
         this._editorService.removeHiddenField(field);
-      });
     }
     if (modelEmpty && (field.templateOptions.hide === true && field.hide === undefined)) {
-      setTimeout(() => {
         field.hide = true;
         this._editorService.addHiddenField(field);
-      });
     }
   }
 
@@ -432,11 +435,9 @@ export class EditorComponent implements OnInit, OnChanges, OnDestroy {
    * Populate the field to add to the TOC
    */
   getTocFields() {
-    setTimeout(() => {
       if (this.fields && this.fields.length > 0) {
         this.tocFields = this.fields[0].fieldGroup.filter(f => f.hide !== true);
       }
-    });
   }
 
   /**