Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The select component in the editor should sort the values only in the suggestions #568

Closed
jma opened this issue Nov 8, 2023 · 0 comments · Fixed by #572
Closed

The select component in the editor should sort the values only in the suggestions #568

jma opened this issue Nov 8, 2023 · 0 comments · Fixed by #572
Assignees
@Garfield-fr

Comments

@jma
Copy link
Contributor

jma commented Nov 8, 2023

When the "SelectWithSort" component is used for multiple values the list of the values are sorted which not reflect the order in the array. The sort operation should be effective only on the suggestion values.

In the follwing example the created_year if at the first place in the list, but as it is sorted it is displayed after bibliothèque.

image
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Dec 11, 2023
@Garfield-fr
editor: fix select sort
8d39c0b 
The "Select an option…" option remains displayed when values are selected.
This option is used to reset the data.

* Keeps selected items in order.
* Improves the select menu by always displaying
  the menu item "Select an option…".
* closes rero#568.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Dec 11, 2023
Merged
@Garfield-fr Garfield-fr self-assigned this Dec 11, 2023
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Dec 12, 2023
@Garfield-fr
editor: fix select sort
66cd529 
The "Select an option…" option remains displayed when values are selected.
This option is used to reset the data.

* Keeps selected items in order.
* Improves the select menu by always displaying
  the menu item "Select an option…".
* closes rero#568.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Dec 12, 2023
@Garfield-fr
editor: fix select sort
6da1624 
The "Select an option…" option remains displayed when values are selected.
This option is used to reset the data.

* Keeps selected items in order.
* Improves the select menu by always displaying
  the menu item "Select an option…".
* Fixes missing translation.
* closes rero#568.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit that referenced this issue Dec 19, 2023
@Garfield-fr
editor: fix select sort
f578145 
The "Select an option…" option remains displayed when values are selected.
This option is used to reset the data.

* Keeps selected items in order.
* Improves the select menu by always displaying
  the menu item "Select an option…".
* Fixes missing translation.
* closes #568.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit that referenced this issue Dec 20, 2023
@Garfield-fr
editor: fix select sort
43f892b 
The "Select an option…" option remains displayed when values are selected.
This option is used to reset the data.

* Keeps selected items in order.
* Improves the select menu by always displaying
  the menu item "Select an option…".
* Fixes missing translation.
* closes #568.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

editor: fix select sort Garfield-fr/ng-core
2 participants
@Garfield-fr @jma