widget: menu widget #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed the tests in that PR #12. After merge, the tests should be OK. |
jma
force-pushed
the
maj-menu-widget
branch
3 times, most recently
from
e93b2b9 to
28398eb
Compare
AoNoOokami
approved these changes
Oct 8, 2019
|
Shall we uniformize commit messages with rero-ils ones? (Co-Authored-by instead of Signed-off-by) |
|
@jma Does this project follow the same commit messages best practices? 🙂 @AoNoOokami Oh, sorry, I didn't read your own comment on this very topic! |
sebdeleze
suggested changes
Oct 9, 2019
| import { Pipe, PipeTransform } from '@angular/core'; | ||
|
|
||
| @Pipe({ | ||
| name: 'callback' |
There was a problem hiding this comment.
I think "callback" is too generalistic, maybe callbackArrayFilter or something like that would be better. But the way to do it is very clean
|
@iGormilhit, @AoNoOokami Until now this project follow the SONAR git commit message convention. This will be update in a next PR to move to the new convention. |
* NEW Adds a new menu widget. * NEW Adds a new callback pipe to filer lists in templates. * BETTER Alert widget has been moved to the main component. * FIX The nav bar menu is responsive. Signed-off-by: Johnny Mariéthoz <johnny.mariethoz@rero.ch>
sebdeleze
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Johnny Mariéthoz johnny.mariethoz@rero.ch