fix: correct method to get pid from $ref #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Corrects method to get pid from $ref. * Adds unit tests to check the method. Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami
force-pushed
the
zaa-#1118-redirect-after-save
branch
from
54831ec to
370fe46
Compare
7 tasks
AoNoOokami
requested review from
Garfield-fr,
benerken,
blankoworld,
iGormilhit,
jma,
sebdeleze and
zannkukai
Garfield-fr
approved these changes
Jan 6, 2020
iGormilhit
approved these changes
Jan 7, 2020
sebdeleze
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Alicia Zangger alicia.zangger@rero.ch
Why are you opening this PR?
To correct the method for getting pid from $ref.
https://tree.taiga.io/project/rero21-reroils/task/1116?kanban-status=1224895
How to test?
Tested with unit tests.
Is needed in rero/rero-ils-ui#92
Code review check list