Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor: support validator with expression and message #113

Merged
merged 1 commit into from
Jan 21, 2020
Merged

editor: support validator with expression and message #113

merged 1 commit into from
Jan 21, 2020

Conversation

Garfield-fr
Copy link
Contributor

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

  • add sync validators.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@Garfield-fr
editor: support validator with expression and message
d8d736d 
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr requested review from jma and sebdeleze January 16, 2020 14:07
@Garfield-fr Garfield-fr mentioned this pull request Jan 16, 2020
Merged
6 tasks
@sebdeleze sebdeleze merged commit 7448ad5 into rero:dev Jan 21, 2020
@Garfield-fr Garfield-fr deleted the zub-editor-validators branch January 30, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebdeleze sebdeleze sebdeleze approved these changes

@jma jma Awaiting requested review from jma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Garfield-fr @sebdeleze